Ticket #2156: 2156_1.patch

_source/internals/fckxhtml.js

@@ -56 +56 @@
         else
                 this._AppendChildNodes( this.MainNode, node, false ) ;
 
+        /**
+         * FCKXHtml._AppendNode() marks DOM element objects it has 
+         * processed by adding a property called _fckxhtmljob, 
+         * setting it equal to the value of FCKXHtml.CurrentJobNum.  
+         * On Internet Explorer, if an element object has such a 
+         * property,  it will show up in the object's attributes 
+         * NamedNodeMap, and the corresponding Attr object in 
+         * that collection  will have is specified property set 
+         * to true.  This trips up code elsewhere that checks to 
+         * see if an element is free of attributes before proceeding 
+         * with an edit operation (c.f. FCK.Style.RemoveFromRange())
+         *      
+         * refs #2156 and #2834
+         */
+        if ( FCKBrowserInfo.IsIE )
+                FCKXHtml._RemoveXHtmlJobProperties( node ) ;
+
         // Get the resulting XHTML as a string.
         var sXHTML = this._GetMainXmlString() ;
 

_source/internals/fckxhtml_ie.js

@@ -92 +92 @@
         }
 }
 
+/**
+ * Used to clean up HTML that has been processed FCKXHtml._AppendNode().
+ *
+ * For objects corresponding to HTML elements, Internet Explorer will 
+ * treat a property as if it were an attribute set on that element.
+ *
+ * http://msdn.microsoft.com/en-us/library/ms533026(VS.85).aspx#Accessing_Element_Pr
+ *
+ * FCKXHtml._AppendNode() sets the property _fckxhtmljob on node objects
+ * corresponding HTML elements to mark them as having been processed.
+ * Counting these properties as attributes will cripple style removal
+ * because FCK.Styles.RemoveFromSelection() will not remove an element
+ * as long as it still has attributes.
+ *
+ * refs #2156 and #2834
+ */
+
+FCKXHtml._RemoveXHtmlJobProperties = function ( node ) 
+{
+        // Protect against degenerate cases.
+        if ( ( typeof node !== 'object' ) || ( node === null ) )
+                return ;
+
+        // Protect against being passed a non-DOMNode object.
+        if ( typeof node.nodeType === 'undefined' ) 
+                return ;
+
+        // Select only nodes of type ELEMENT_NODE
+        if ( node.nodeType === 1 ) 
+        {
+        
+                // Clear the _fckhtmljob attribute.
+                if ( typeof node._fckxhtmljob !== 'undefined' )
+                        node._fckhtmljob = null ;
+
+                // Recurse upon child nodess.
+                if ( node.hasChildNodes() ) 
+                {
+                        var childNodes = node.childNodes ;
+                        for ( var i = 0 ; i < childNodes.length ; ++i ) 
+                                FCKXHtml._RemoveXHtmlJobProperties( childNodes.item(i) ) ;
+                }
+        }
+}
+
 // On very rare cases, IE is loosing the "align" attribute for DIV. (right align and apply bulleted list)
 FCKXHtml.TagProcessors['div'] = function( node, htmlNode )
 {