Ticket #3884: 3884.patch

_source/tests/plugins/htmldataprocessor/htmldataprocessor.html

@@ -270 +270 @@
                                 dataProcessor.toDataFormat( protectedHtml ) );
                 },
 
+                /**
+                 * Test empty value attributes.
+                 */
+                test_ticket_3884 : function()
+                {
+                        var editor = CKEDITOR.instances.editor1,
+                                dataProcessor = editor.dataProcessor;
+                        dataProcessor.writer = new CKEDITOR.htmlParser.basicWriter();
 
+                        assert.areSame( '<p><a href="" name="">emptylink</a></p>',
+                                dataProcessor.toDataFormat( dataProcessor.toHtml( '<p><a href="" name="">emptylink</a></p>' ) ) );
+                },
+
                 name : document.title
         };
 })() );
 
-//window.onload = testCase.test_ticket_3407;
+//window.onload = testCase.test_ticket_3884;
         //]]>
         </script>
 </head>

_source/plugins/htmldataprocessor/plugin.js

@@ -114 +114 @@
 
                                         if ( attribs )
                                         {
-                                                // Remove duplicates that have been saved with our
-                                                // special names.
-                                                if ( attribs._cke_saved_name )
-                                                        delete attribs.name;
-                                                if ( attribs._cke_saved_href )
-                                                        delete attribs.href;
-                                                if ( attribs._cke_saved_src )
-                                                        delete attribs.src;
-                                        }
+                                                var attributeNames = [ 'name', 'href', 'src' ],
+                                                        savedAttributeName;
+                                                for ( var i = 0 ; i < attributeNames.length ; i++ )
+                                                {
+                                                        savedAttributeName = '_cke_saved_' + attributeNames[ i ];
+                                                        savedAttributeName in attribs && ( delete attribs[ savedAttributeName ] );
+                                                }
+                                        }
                                 },
 
                                 embed : function( element )

CHANGES.html

@@ -92 +92 @@
                         source code.</li>
                 <li><a href="http://dev.fckeditor.net/ticket/3639">#3639</a> : Button size was inconsistent.</li>
                 <li><a href="http://dev.fckeditor.net/ticket/3874">#3874</a> : Paste as plain text in Safari loosing lines.</li>
+                <li><a href="http://dev.fckeditor.net/ticket/3884">#3884</a> : Empty "href" attribute was duplicated on output data.</li>
         </ul>
         <h3>
                 CKEditor 3.0 RC</h3>