Ticket #3988: 3988.patch

_source/core/editor.js

@@ -283 +283 @@
                         var form = element.$.form && new CKEDITOR.dom.element( element.$.form );
                         if ( form )
                         {
-                                form.on( 'submit', function()
-                                        {
-                                                editor.updateElement();
-                                        });
+                                function onSubmit()
+                                {
+                                        editor.updateElement();
+                                }
+                                form.on( 'submit',onSubmit );
 
                                 // Setup the submit function because it doesn't fire the
                                 // "submit" event.
                                 if ( !form.$.submit.nodeName )
                                 {
-                                        form.$.submit = CKEDITOR.tools.override( form.$.submit, function( originalSubmit )
-                                                {
-                                                        return function()
-                                                                {
-                                                                        editor.updateElement();
+                                        function submitHandler( originalSubmit )
+                                        {
+                                                return function()
+                                                        {
+                                                                editor.updateElement();
 
-                                                                        // For IE, the DOM submit function is not a
-                                                                        // function, so we need thid check.
-                                                                        if ( originalSubmit.apply )
-                                                                                originalSubmit.apply( this, arguments );
-                                                                        else
-                                                                                originalSubmit();
-                                                                };
-                                                });
-                                }
-                        }
-                }
+                                                                // For IE, the DOM submit function is not a
+                                                                // function, so we need thid check.
+                                                                if ( originalSubmit.apply )
+                                                                        originalSubmit.apply( this, arguments );
+                                                                else
+                                                                        originalSubmit();
+                                                        };
+                                        }
+
+                                        var originalSubmit = form.$.submit;
+                                        form.$.submit = CKEDITOR.tools.override( form.$.submit, submitHandler );
+                                }
+
+                                // Remove all 'submit' events registered on form element before destroying.(#3988)
+                                editor.on( 'beforeDestroy', function()
+                                {
+                                        form.removeListener( 'submit', onSubmit );
+                                        if ( originalSubmit )
+                                                form.$.submit = originalSubmit;
+                                } );
+                        }
+                }
         };
 
         function updateCommandsMode()
@@ -447 +459 @@
                  */
                 destroy : function( noUpdate )
                 {
+                        this.fire( 'beforeDestroy' );
                         if ( !noUpdate )
                                 this.updateElement();
-
                         this.theme.destroy( this );
                         CKEDITOR.remove( this );
                 },

CHANGES.html

@@ -153 +153 @@
                 <li><a href="http://dev.fckeditor.net/ticket/3793">#3793</a> : Combined images into sprites.</li>
                 <li><a href="http://dev.fckeditor.net/ticket/3783">#3783</a> : Fixed indenting command in table cells create collapsed paragraph.</li>
                 <li><a href="http://dev.fckeditor.net/ticket/3968">#3968</a> : About dialog layout was broken with IE+Standards+RTL.</li>               
+                <li><a href="http://dev.fckeditor.net/ticket/3988">#3988</a> : Destroy editor on form submit event cause error.</li>            
         </ul>
         <h3>
                 CKEditor 3.0 RC</h3>