Ticket #7366: 7366.patch

_source/plugins/clipboard/plugin.js

@@ -9 +9 @@
 
 (function()
 {
+        // Safari doesn't like 'beforepaste' event - it sometimes doesn't
+        // properly handles ctrl+c. Probably some race-condition between events.
+        // Chrome and Firefox works well with both events, so better to use 'paste'
+        // which will handle pasting from e.g. browsers' menu bars.
+        // IE7/8 doesn't like 'paste' event for which it's throwing random errors.
+        var mainPasteEvent = CKEDITOR.env.ie ? 'beforepaste' : 'paste';
+
         // Tries to execute any of the paste, cut or copy commands in IE. Returns a
         // boolean indicating that the operation succeeded.
         var execIECommand = function( editor, command )
@@ -92 +99 @@
                                         // Prevent IE from pasting at the begining of the document.
                                         editor.focus();
 
-                                        if ( !editor.document.getBody().fire( 'beforepaste' )
+                                        // Command will be handled by 'beforepaste', but as
+                                        // execIECommand( 'paste' ) will fire also 'paste' event
+                                        // we're canceling it.
+                                        depressPasteEventNow();
+
+                                        if ( !editor.document.getBody().fire( mainPasteEvent )
                                                  && !execIECommand( editor, 'paste' ) )
                                         {
                                                 editor.fire( 'pasteDialog' );
@@ -104 +116 @@
                                 {
                                         try
                                         {
-                                                if ( !editor.document.getBody().fire( 'beforepaste' )
+                                                if ( !editor.document.getBody().fire( mainPasteEvent )
                                                          && !editor.document.$.execCommand( 'Paste', false, null ) )
                                                 {
                                                         throw 0;
@@ -134 +146 @@
                         case CKEDITOR.SHIFT + 45 :              // SHIFT+INS
 
                                 var body = this.document.getBody();
+                                        
+                                // Cancel 'paste' event because ctrl+v is for IE handled
+                                // by 'beforepaste'.
+                                depressPasteEventNow();
 
                                 // Simulate 'beforepaste' event for all none-IEs.
                                 if ( !CKEDITOR.env.ie && body.fire( 'beforepaste' ) )
@@ -275 +291 @@
                 }
         }
 
-        var depressBeforeEvent;
+        var depressBeforePasteEvent;
         function stateFromNamedCommand( command, editor )
         {
                 // IE Bug: queryCommandEnabled('paste') fires also 'beforepaste(copy/cut)',
                 // guard to distinguish from the ordinary sources( either
                 // keyboard paste or execCommand ) (#4874).
-                CKEDITOR.env.ie && ( depressBeforeEvent = 1 );
+                CKEDITOR.env.ie && ( depressBeforePasteEvent = 1 );
 
                 var retval = CKEDITOR.TRISTATE_OFF;
                 try { retval = editor.document.$.queryCommandEnabled( command ) ? CKEDITOR.TRISTATE_OFF : CKEDITOR.TRISTATE_DISABLED; }catch( er ){}
 
-                depressBeforeEvent = 0;
+                depressBeforePasteEvent = 0;
                 return retval;
         }
 
@@ -303 +319 @@
                 this.fire( 'pasteState', pasteState );
         }
 
+        var depressPasteEvent = 0;
+        function depressPasteEventNow()
+        {
+                depressPasteEvent = 1;
+                // For safety reason we should wait longer than 0/1ms.
+                // We don't know how long execution of quite complex getClipboardData will take 
+                // and in for example 'paste' listner execCommand() (which fires 'paste') is called
+                // after getClipboardData finishes.
+                // Luckily, it's impossible to immediately fire another 'paste' event we want to handle,
+                // because we only handle there native context menu and menu bar.
+                setTimeout( function() { depressPasteEvent = 0; }, 100 );
+        }
+
         // Register the plugin.
         CKEDITOR.plugins.add( 'clipboard',
                 {
@@ -375 +404 @@
                                 editor.on( 'contentDom', function()
                                 {
                                         var body = editor.document.getBody();
-                                        body.on( CKEDITOR.env.webkit ? 'paste' : 'beforepaste', function( evt )
+                                        body.on( mainPasteEvent, function( evt )
                                                 {
-                                                        if ( depressBeforeEvent )
+                                                        if ( CKEDITOR.env.ie && depressBeforePasteEvent )
                                                                 return;
 
                                                         // Fire 'beforePaste' event so clipboard flavor get customized
@@ -398 +427 @@
                                                         } );
                                                 });
 
+                                        CKEDITOR.env.ie && body.on( 'paste', function( evt )
+                                                {
+                                                        if ( depressPasteEvent )
+                                                                return;
+
+                                                        // Cancel next 'paste' event fired by execIECommand( 'paste' )
+                                                        // at the end of this callback.
+                                                        depressPasteEventNow();
+
+                                                        // Prevent native paste.
+                                                        evt.data.preventDefault();
+
+                                                        // Fire 'beforePaste' event so clipboard flavor get customized
+                                                        // by other plugins.
+                                                        var eventData =  { mode : 'html' };
+                                                        editor.fire( 'beforePaste', eventData );
+
+                                                        getClipboardData.call( editor, evt, eventData.mode, function ( data )
+                                                        {
+                                                                // The very last guard to make sure the
+                                                                // paste has successfully happened.
+                                                                if ( !( data = CKEDITOR.tools.trim( data.replace( /<span[^>]+data-cke-bookmark[^<]*?<\/span>/ig,'' ) ) ) )
+                                                                        return;
+
+                                                                var dataTransfer = {};
+                                                                dataTransfer[ eventData.mode ] = data;
+                                                                editor.fire( 'paste', dataTransfer );
+                                                        } );
+
+                                                        // Force IE to paste content into pastebin so pasteDataFromClipboard will work.
+                                                        execIECommand( editor, 'paste' );
+                                                });
+
                                         // Dismiss the (wrong) 'beforepaste' event fired on context menu open. (#7953)
                                         body.on( 'contextmenu', function()
                                         {
-                                                depressBeforeEvent = 1;
-                                                setTimeout( function() { depressBeforeEvent = 0; }, 10 );
+                                                depressBeforePasteEvent = 1;
+                                                setTimeout( function() { depressBeforePasteEvent = 0; }, 10 );
                                         });
 
-                                        body.on( 'beforecut', function() { !depressBeforeEvent && fixCut( editor ); } );
+                                        body.on( 'beforecut', function() { !depressBeforePasteEvent && fixCut( editor ); } );
 
                                         body.on( 'mouseup', function(){ setTimeout( function(){ setToolbarStates.call( editor ); }, 0 ); }, editor );
                                         body.on( 'keyup', setToolbarStates, editor );