Ticket #7907: 7907_3.patch

_source/plugins/list/plugin.js

@@ -102 +102 @@
                                 indentLevel = Math.max( listArray[ baseIndex ].indent, 0 ),
                                 currentListItem = null,
                                 orgDir,
+                                block,
                                 paragraphName = ( paragraphMode == CKEDITOR.ENTER_P ? 'p' : 'div' );
                         while ( 1 )
                         {
@@ -146 +147 @@
                                         if ( listNodeNames[ item.grandparent.getName() ] )
                                                 currentListItem = item.element.clone( false, true );
                                         else
+                                                currentListItem = new CKEDITOR.dom.documentFragment( doc );
+
+                                        // Migrate all children to the new container,
+                                        // apply the proper text direction.
+                                        var dirLoose = item.grandparent.getDirection( 1 ) != orgDir,
+                                                enterBr = paragraphMode == CKEDITOR.ENTER_BR,
+                                                li = item.element,
+                                                className = li.getAttribute( 'class' ),
+                                                style = li.getAttribute( 'style' );
+
+                                        for ( var i = 0, child, count = item.contents.length; i < count; i++ )
                                         {
-                                                // Create completely new blocks here.
-                                                if ( dir || item.element.hasAttributes() || paragraphMode != CKEDITOR.ENTER_BR )
+                                                child = item.contents[ i ];
+
+                                                if ( child.type == CKEDITOR.NODE_ELEMENT && child.isBlockBoundary() )
                                                 {
-                                                        currentListItem = doc.createElement( paragraphName );
-                                                        item.element.copyAttributes( currentListItem, { type:1, value:1 } );
+                                                        // Apply direction on content blocks.
+                                                        if ( dirLoose && !child.getDirection() )
+                                                                child.setAttribute( 'dir', orgDir );
 
-                                                        // There might be a case where there are no attributes in the element after all
-                                                        // (i.e. when "type" or "value" are the only attributes set). In this case, if enterMode = BR,
-                                                        // the current item should be a fragment.
-                                                        if ( !dir && paragraphMode == CKEDITOR.ENTER_BR && !currentListItem.hasAttributes() )
-                                                                currentListItem = new CKEDITOR.dom.documentFragment( doc );
+                                                        // Merge into child styles.
+                                                        style && child.setAttribute( 'style', style + child.getAttribute( 'style' ) || '' );
+                                                        className && child.addClass( className );
                                                 }
-                                                else
-                                                        currentListItem = new CKEDITOR.dom.documentFragment( doc );
-                                        }
+                                                else if ( dirLoose || !enterBr || style || className )
+                                                {
+                                                        // Establish new block to hold text direction and styles.
+                                                        if ( !block )
+                                                        {
+                                                                block = doc.createElement( paragraphName );
+                                                                dirLoose && block.setAttribute( 'dir', orgDir );
+                                                        }
 
-                                        if ( currentListItem.type == CKEDITOR.NODE_ELEMENT )
-                                        {
-                                                if ( item.grandparent.getDirection( 1 ) != orgDir )
-                                                        currentListItem.setAttribute( 'dir', orgDir );
-                                        }
+                                                        // Copy over styles to new block;
+                                                        style && block.setAttribute( 'style', style );
+                                                        className && block.setAttribute( 'class', className );
+
+                                                        block.append( child.clone( 1, 1 ) );
+                                                }
 
-                                        for ( i = 0 ; i < item.contents.length ; i++ )
-                                                currentListItem.append( item.contents[i].clone( 1, 1 ) );
+                                                currentListItem.append( block || child.clone( 1, 1 ) );
+                                        }
 
                                         if ( currentListItem.type == CKEDITOR.NODE_DOCUMENT_FRAGMENT
                                                  && currentIndex != listArray.length - 1 )
@@ -190 +208 @@
                                                 }
                                         }
 
-                                        if ( currentListItem.type == CKEDITOR.NODE_ELEMENT &&
-                                                        currentListItem.getName() == paragraphName &&
-                                                        currentListItem.$.firstChild )
-                                        {
-                                                currentListItem.trim();
-                                                var firstChild = currentListItem.getFirst();
-                                                if ( firstChild.type == CKEDITOR.NODE_ELEMENT && firstChild.isBlockBoundary() )
-                                                {
-                                                        var tmp = new CKEDITOR.dom.documentFragment( doc );
-                                                        currentListItem.moveChildren( tmp );
-                                                        currentListItem = tmp;
-                                                }
-                                        }
-
                                         var currentListItemName = currentListItem.$.nodeName.toLowerCase();
                                         if ( !CKEDITOR.env.ie && ( currentListItemName == 'div' || currentListItemName == 'p' ) )
                                                 currentListItem.appendBogus();
@@ -214 +218 @@
                                 else
                                         return null;
 
+                                block = null;
+
                                 if ( listArray.length <= currentIndex || Math.max( listArray[ currentIndex ].indent, 0 ) < indentLevel )
                                         break;
                         }
@@ -378 +384 @@
 
                 listsCreated.push( listNode );
 
-                var contentBlock, listItem;
+                var contentBlock, blockDir, listItem;
 
                 while ( listContents.length )
                 {
                         contentBlock = listContents.shift();
                         listItem = doc.createElement( 'li' );
 
-                        // Preserve preformat block and heading structure when converting to list item. (#5335) (#5271)
-                        if ( contentBlock.is( 'pre' ) || headerTagRegex.test( contentBlock.getName() ) )
+                        // Take it off the tree to void bothering
+                        // the direction change event.
+                        contentBlock.remove();
+
+                        if ( blockDir = contentBlock.getDirection() )
+                        {
+                                contentBlock.removeStyle( 'direction' );
+                                contentBlock.removeAttribute( 'dir' );
+                        }
+
+                        // Preserve the block when converting to list item if:
+                        // 1. In preformat; (#5335)
+                        // 2. In heading structure; (#5271)
+                        // 3. Styled or attributed. (#6461)
+                        if ( contentBlock.is( 'pre' )
+                                 || headerTagRegex.test( contentBlock.getName() )
+                                 || contentBlock.hasAttributes() )
                                 contentBlock.appendTo( listItem );
                         else
                         {
-                                contentBlock.copyAttributes( listItem );
-                                // Remove direction attribute after it was merged into list root. (#7657)
-                                if ( listDir && contentBlock.getDirection() )
-                                {
-                                        listItem.removeStyle( 'direction' );
-                                        listItem.removeAttribute( 'dir' );
-                                }
                                 contentBlock.moveChildren( listItem );
                                 contentBlock.remove();
                         }
+
+                        // Apply text direction on list item unless it's already applied on root. (#7657)
+                        if ( blockDir && !listDir )
+                                listItem.setAttribute( 'dir', blockDir );
 
                         listItem.appendTo( listNode );
                 }