Changeset 4443

Timestamp:

11/10/09 07:11:46 (4 years ago)

Author:

garry.yao

Message:

Fixing #4401 : customized by removing 'upload' tab page from 'Link dialog' cause JavaScript error.

Location:

CKEditor/trunk

Files:

• CHANGES.html (modified) (1 diff)
• _source/plugins/link/dialogs/link.js (modified) (1 diff)

CKEditor/trunk/CHANGES.html

@@ -48 +48 @@
                 <li><a href="http://dev.fckeditor.net/ticket/3918">#3918</a> : Fixed fake object is editable with Image dialog.</li>
                 <li><a href="http://dev.fckeditor.net/ticket/4053">#4053</a> : Fixed 'Form Properties' missing from context menu when selection collapsed inside form.</li>
+                <li><a href="http://dev.fckeditor.net/ticket/4401">#4401</a> : Fixed customized by removing 'upload' tab page from 'Link dialog' cause JavaScript error.</li>
         </ul>
         <h3>

CKEditor/trunk/_source/plugins/link/dialogs/link.js

@@ -38 +38 @@
                         partIds = [ 'urlOptions', 'anchorOptions', 'emailOptions' ],
                         typeValue = this.getValue(),
-                        uploadInitiallyHidden = dialog.definition.getContents( 'upload' ).hidden;
+                        uploadTab = dialog.definition.getContents( 'upload' ),
+                        uploadInitiallyHidden = uploadTab && uploadTab.hidden;
 
                 if ( typeValue == 'url' )