Changeset 4897

Timestamp:

01/07/10 10:58:18 (3 years ago)

Author:

garry.yao

Message:

Use 'aria-describedby' to indicate selected combo value (intead of using 'title' on combo button link).

File:

• CKEditor/branches/features/aria/_source/plugins/richcombo/plugin.js (modified) (3 diffs)

CKEditor/branches/features/aria/_source/plugins/richcombo/plugin.js

@@ -166 +166 @@
                                         '<span id="' + id+ '_label" class=cke_label>', this.label, '</span>' +
                                         '<a hidefocus=true title="', this.title, '" tabindex="-1" href="javascript:void(\'', this.label, '\')"' +
-                                                ' role="button" aria-labelledby="', id ,'_label"' );
+                                                ' role="button" aria-labelledby="', id , '_label" aria-describedby="', id, '_text"' );
 
                         // Some browsers don't cancel key events in the keydown but in the
@@ -282 +282 @@
                         this._.value = value;
 
-                        var element = this.document.getById( 'cke_' + this.id )
-                                                                .getElementsByTag( 'a' ).getItem( 0 ),
-                                 textElement = this.document.getById( 'cke_' + this.id + '_text' );
+                        var textElement = this.document.getById( 'cke_' + this.id + '_text' );
 
                         if ( !( value || text ) )
@@ -293 +291 @@
                         else
                                 textElement.removeClass( 'cke_inline_label' );
+
                         textElement.setHtml( typeof text != 'undefined' ? text : value );
-
-                        // Update link 'tilte' to represent the currectly selected combo value.
-                        element.setAttribute( 'title', typeof text != 'undefined' ? text : value );
                 },