Changeset 5102

Timestamp:

2010-02-12 12:48:59 (2 years ago)

Author:

garry.yao

Message:

Fixing [4611]: Range measure around select is buggy in IE7, safe guard by adding a try..catch.

Location:

CKEditor/trunk

Files:

• CHANGES.html (modified) (1 diff)
• _source/plugins/selection/plugin.js (modified) (1 diff)

CKEditor/trunk/CHANGES.html

@@ -88 +88 @@
                 <li><a href="http://dev.fckeditor.net/ticket/5123">#5123</a> : Fixed broken XHTML in User Interface Languages sample.</li>
                 <li><a href="http://dev.fckeditor.net/ticket/4893">#4893</a> : Editor should understand table cell inline styles.</li>
+                <li><a href="http://dev.fckeditor.net/ticket/4611">#4611</a> : Selection around &lt;select&gt; in editor doesn't anymore cause error.</li>
                 <li>Updated the following language files:<ul>
                         <li><a href="http://dev.fckeditor.net/ticket/5006">#5006</a> : Dutch;</li>

CKEditor/trunk/_source/plugins/selection/plugin.js

@@ -507 +507 @@
                                                 var distance = testRange.text.replace( /(\r\n|\r)/g, '\n' ).length;
 
-                                                while ( distance > 0 )
-                                                        distance -= siblings[ --i ].nodeValue.length;
+                                                try
+                                                {
+                                                        while ( distance > 0 )
+                                                                distance -= siblings[ --i ].nodeValue.length;
+                                                }
+                                                // Measurement in IE could be somtimes wrong because of <select> element. (#4611)
+                                                catch( e )
+                                                {
+                                                        distance = 0;
+                                                }
+
 
                                                 if ( distance === 0 )