Changeset 5105

Timestamp:

02/12/10 13:50:05 (3 years ago)

Author:

garry.yao

Message:

Fixing #5127: Safe guard the page element retrieving logics in dialog system.

Location:

CKEditor/trunk

Files:

• CHANGES.html (modified) (1 diff)
• _source/plugins/dialog/plugin.js (modified) (1 diff)

CKEditor/trunk/CHANGES.html

@@ -91 +91 @@
                 <li><a href="http://dev.fckeditor.net/ticket/4886">#4886</a> : Extra BR tags were being created in the output HTML.</li>
                 <li><a href="http://dev.fckeditor.net/ticket/4933">#4933</a> : Empty tags with BR were being left in the DOM.</li>
+                <li><a href="http://dev.fckeditor.net/ticket/5127">#5127</a> : Remove dialog definition pages somtimes been error prone.</li>
                 <li>Updated the following language files:<ul>
                         <li><a href="http://dev.fckeditor.net/ticket/5006">#5006</a> : Dutch;</li>

CKEditor/trunk/_source/plugins/dialog/plugin.js

@@ -950 +950 @@
                 getContentElement : function( pageId, elementId )
                 {
-                        return this._.contents[pageId][elementId];
+                        var page = this._.contents[ pageId ];
+                        return page && page[ elementId ];
                 },