Changeset 5511

Timestamp:

05/21/10 17:56:47 (3 years ago)

Author:

garry.yao

Message:

#5719: Avoid firing 'change' event on field when dialog is already closed.

Location:

CKEditor/trunk

Files:

• CHANGES.html (modified) (1 diff)
• _source/plugins/dialogui/plugin.js (modified) (1 diff)

CKEditor/trunk/CHANGES.html

@@ -96 +96 @@
                 <li><a href="http://dev.fckeditor.net/ticket/5688">#5688</a> : Duplicate ids are used in dialog definition.</li>
                 <li><a href="http://dev.fckeditor.net/ticket/5570">#5570</a> : [IE] First enabling SCAYT blind cursor in editor.</li>
+                <li><a href="http://dev.fckeditor.net/ticket/5719">#5719</a> : [IE] 'change' dialog event should not be triggered when dialog is already closed.</li>
                 <li>Updated the following language files:<ul>
                         <li><a href="http://dev.fckeditor.net/ticket/5432">#5432</a> : Dutch;</li>

CKEditor/trunk/_source/plugins/dialogui/plugin.js

@@ -88 +88 @@
                                         dialog.on( 'load', function()
                                                 {
-                                                        this.getInputElement().on( 'change', function(){ this.fire( 'change', { value : this.getValue() } ); }, this );
+                                                        this.getInputElement().on( 'change', function()
+                                                        {
+                                                                // Make sure 'onchange' doesn't get fired after dialog closed. (#5719)
+                                                                if ( !dialog.parts.dialog.isVisible() )
+                                                                        return;
+                                                                
+                                                                this.fire( 'change', { value : this.getValue() } );
+                                                        }, this );
                                                 }, this );
                                         this._.domOnChangeRegistered = true;