Changeset 6029

Timestamp:

11/01/10 05:59:51 (3 years ago)

Author:

garry.yao

Message:

#6534: Workaround to cancel 'contextmenu' event on Opera when trigged by Windows 'menu key'.

Location:

CKEditor/trunk

Files:

• CHANGES.html (modified) (1 diff)
• _source/plugins/contextmenu/plugin.js (modified) (2 diffs)

CKEditor/trunk/CHANGES.html

@@ -79 +79 @@
                 <li><a href="http://dev.ckeditor.com/ticket/6403">#6403</a> : [Opera] Font name options is not correctly marked in dropdown list.</li>
                 <li><a href="http://dev.ckeditor.com/ticket/4534">#4534</a> : [Opera] Arrow key to navigate through combo list has side effects of window scrolling.</li>
+                <li><a href="http://dev.ckeditor.com/ticket/6534">#6534</a> : [Opera] Menu key brings up both CKEditor and browser context menu.</li>
                 <li><a href="http://dev.ckeditor.com/ticket/6416">#6416</a> : [IE9] Unable to make text selection with mouse in source area.</li>
                 <li><a href="http://dev.ckeditor.com/ticket/6417">#6417</a> : [IE9] Context menu opens at the upper-left corner always.</li>

CKEditor/trunk/_source/plugins/contextmenu/plugin.js

@@ -1 @@
-/*
+/*
 Copyright (c) 2003-2010, CKSource - Frederico Knabben. All rights reserved.
 For licensing, see LICENSE.html or http://ckeditor.com/license
@@ -225 +225 @@
                                 },
                                 this );
+
+                        if ( CKEDITOR.env.opera )
+                        {
+                                // 'contextmenu' event triggered by Windows menu key is unpreventable,
+                                // cancel the key event itself. (#6534)  
+                                element.on( 'keypress' , function ( evt )
+                                {
+                                        var domEvent = evt.data;
+
+                                        if ( domEvent.$.keyCode == 0 )
+                                                domEvent.preventDefault();
+                                });
+                        }
 
                         if ( CKEDITOR.env.webkit )