Changeset 6547 for CKEditor/trunk

Timestamp:

03/14/11 15:44:48 (2 years ago)

Author:

Saare

Message:

#7300: Numeric values were not loaded correctly in the link dialog.

Location:

CKEditor/trunk

Files:

• CHANGES.html (modified) (1 diff)
• _source/plugins/link/dialogs/link.js (modified) (1 diff)

CKEditor/trunk/CHANGES.html

@@ -67 +67 @@
                 <li><a href="http://dev.ckeditor.com/ticket/7084">#7084</a> : SCAYT dialog window is now working properly with more than one editor instance in a page.</li>
                 <li><a href="http://dev.ckeditor.com/ticket/6662">#6662</a> : [FF] List structure pasting now works with FF4 (RC), which is caused by a regression from FF3.x.</li>
+                <li><a href="http://dev.ckeditor.com/ticket/7300">#7300</a> : Link dialog now loads numeric values correctly.</li>
                 <li>Updated the following language files:<ul>
                         <li><a href="http://dev.ckeditor.com/ticket/7124">#7124</a> : Czech;</li>

CKEditor/trunk/_source/plugins/link/dialogs/link.js

@@ -197 +197 @@
                                         while ( ( featureMatch = popupFeaturesRegex.exec( onclickMatch[2] ) ) )
                                         {
-                                                if ( featureMatch[2] == 'yes' || featureMatch[2] == '1' )
+                                                // Some values should remain numbers (#7300)
+                                                if ( ( featureMatch[2] == 'yes' || featureMatch[2] == '1' ) && !( featureMatch[1] in { height:1, width:1, top:1, left:1 } ) )
                                                         retval.target[ featureMatch[1] ] = true;
                                                 else if ( isFinite( featureMatch[2] ) )