Changeset 6929 for CKEditor/trunk

Timestamp:

05/17/11 15:16:05 (2 years ago)

Author:

Saare

Message:

#7733: Flash movies will be assigned with the data attribute only when required.

Location:

CKEditor/trunk

Files:

• CHANGES.html (modified) (1 diff)
• _source/plugins/flash/dialogs/flash.js (modified) (1 diff)

CKEditor/trunk/CHANGES.html

@@ -55 +55 @@
                 <li><a href="http://dev.ckeditor.com/ticket/6845">#6845</a> : Spaces inside the link field in the link dialog window will now be trimmed.</li>
                 <li><a href="http://dev.ckeditor.com/ticket/7840">#7840</a> : [IE] Opening the Table Properties dialog via the context menu caused a JS error.</li>
+                <li><a href="http://dev.ckeditor.com/ticket/7733">#7733</a> : Flash movies inserted with the flash dialog window were not displaying properly when injected to the page.</li>
                 <li>Updated the following language files:<ul>
                         <li><a href="http://dev.ckeditor.com/ticket/7834">#7834</a> : Dutch;</li>

CKEditor/trunk/_source/plugins/flash/dialogs/flash.js

@@ -125 +125 @@
                         {
                                 case ATTRTYPE_OBJECT:
-                                        if ( !objectNode )
+                                        // Avoid applying the data attribute when not needed (#7733)
+                                        if ( !objectNode || ( attrDef.name == 'data' && embedNode && !objectNode.hasAttribute( 'data' ) ) )
                                                 continue;
                                         var value = this.getValue();