Changeset 7004 for CKEditor/trunk

Timestamp:

06/02/11 17:26:36 (2 years ago)

Author:

garry.yao

Message:

#7959: Place cursor in first table cell after table insertion.

Location:

CKEditor/trunk

Files:

• CHANGES.html (modified) (1 diff)
• _source/plugins/table/dialogs/table.js (modified) (2 diffs)

CKEditor/trunk/CHANGES.html

@@ -47 +47 @@
                 <li><a href="http://dev.ckeditor.com/ticket/7387">#7387</a> : Allow styleDefinitions that can be applied to a set of elements.</li>
                 <li><a href="http://dev.ckeditor.com/ticket/4345">#4345</a> : Added the new "langLoaded" event to CKEDITOR.editor so "by code" language updates can be performed.</li>
+                <li><a href="http://dev.ckeditor.com/ticket/7959">#7959</a> : Table insertion will blink cursor in the first cell.</li>
         </ul>
         <p>

CKEditor/trunk/_source/plugins/table/dialogs/table.js

@@ -107 +107 @@
                         {
                                 var selection = editor.getSelection(),
-                                        bms = selection.createBookmarks();
+                                        bms = this._.selectedElement && selection.createBookmarks();
 
                                 var table = this._.selectedElement || makeElement( 'table' ),
@@ -223 +223 @@
                                 // Insert the table element if we're creating one.
                                 if ( !this._.selectedElement )
+                                {
                                         editor.insertElement( table );
-
+                                        // Override the default cursor position after insertElement to place
+                                        // cursor inside the first cell (#7959), IE needs a while.
+                                        setTimeout( function()
+                                                {
+                                                        var firstCell = new CKEDITOR.dom.element( table.$.rows[ 0 ].cells[ 0 ] );
+                                                        var range = new CKEDITOR.dom.range( editor.document );
+                                                        range.moveToPosition( firstCell, CKEDITOR.POSITION_AFTER_START );
+                                                        range.select( 1 );
+                                                }, 0 );
+                                }
                                 // Properly restore the selection, (#4822) but don't break
                                 // because of this, e.g. updated table caption.
-                                try { selection.selectBookmarks( bms ); } catch( er ){}
-
-                                return true;
+                                else
+                                        try { selection.selectBookmarks( bms ); } catch( er ){}
                         },
                         contents : [