Changeset 7012

Timestamp:

06/06/11 10:10:00 (2 years ago)

Author:

wwalc

Message:

#7981 Iframe dialog not picking width & height values entered in source view

Location:

CKEditor/trunk/_source

Files:

• core/tools.js (modified) (1 diff)
• plugins/fakeobjects/plugin.js (modified) (1 diff)
• plugins/iframe/dialogs/iframe.js (modified) (4 diffs)
• plugins/pastefromword/filter/default.js (modified) (4 diffs)

CKEditor/trunk/_source/core/tools.js

@@ -688 +688 @@
 
                 /**
+                 * Convert the specified CSS length value to the calculated pixel length inside this page.
+                 * <strong>Note:</strong> Percentage based value is left intact.
+                 * @param {String} cssLength CSS length value.
+                 */
+                convertToPx : ( function ()
+                        {
+                                var calculator;
+
+                                return function( cssLength )
+                                {
+                                        if ( !calculator )
+                                        {
+                                                calculator = CKEDITOR.dom.element.createFromHtml(
+                                                                '<div style="position:absolute;left:-9999px;' +
+                                                                'top:-9999px;margin:0px;padding:0px;border:0px;"' +
+                                                                '></div>', CKEDITOR.document );
+                                                CKEDITOR.document.getBody().append( calculator );
+                                        }
+
+                                        if ( !/%$/.test( cssLength ) )
+                                        {
+                                                calculator.setStyle( 'width', cssLength );
+                                                return calculator.$.clientWidth;
+                                        }
+
+                                        return cssLength;
+                                };
+                        } )(),
+
+                /**
                  * String specified by {@param str} repeats {@param times} times.
                  * @param str

CKEditor/trunk/_source/plugins/fakeobjects/plugin.js

@@ -34 +34 @@
 
                                                 if ( width )
-                                                        realElement.attributes.width = width;
+                                                        realElement.attributes.width = CKEDITOR.tools.convertToPx( width );
 
                                                 if ( height )
-                                                        realElement.attributes.height = height;
+                                                        realElement.attributes.height = CKEDITOR.tools.convertToPx( height );
                                         }
                                 }

CKEditor/trunk/_source/plugins/iframe/dialogs/iframe.js

@@ -51 +51 @@
                         minWidth : 350,
                         minHeight : 260,
-                        onLoad : function()
-                        {
-                                var dialog = this,
-                                        styles = dialog.getContentElement( 'advanced', 'advStyles' );
-
-                                styles && styles.on( 'change', function()
-                                        {
-                                                // Synchronize width value.
-                                                var width = this.getStyle( 'width', '' ),
-                                                        txtWidth = dialog.getContentElement( 'info', 'width' );
-
-                                                txtWidth && txtWidth.setValue( width, true );
-
-                                                // Synchronize height value.
-                                                var height = this.getStyle( 'height', '' ),
-                                                        txtHeight = dialog.getContentElement( 'info', 'height' );
-
-                                                txtHeight && txtHeight.setValue( height, true );
-                                        });
-                        },
                         onShow : function()
                         {
@@ -84 +64 @@
                                         this.iframeNode = iframeNode;
 
-                                        this.setupContent( iframeNode, fakeImage );
+                                        this.setupContent( iframeNode );
                                 }
-
-                                // Call the onChange method for the widht and height fields so
-                                // they get reflected into the Advanced tab.
-                                var widthInput = this.getContentElement( 'info', 'width' ),
-                                        heightInput = this.getContentElement( 'info', 'height' );
-                                widthInput && widthInput.onChange();
-                                heightInput && heightInput.onChange();
                         },
                         onOk : function()
@@ -165 +138 @@
                                                                                 var val = this.getValue();
                                                                                 val && ( extraStyles.width = val );
-                                                                        },
-                                                                        onChange : function()
-                                                                        {
-                                                                                var styles = this.getDialog().getContentElement( 'advanced', 'advStyles' ),
-                                                                                        value = this.getValue();
-                                                                                styles && styles.updateStyle( 'width', value );
                                                                         }
                                                                 },
@@ -191 +158 @@
                                                                                 var val = this.getValue();
                                                                                 val && ( extraStyles.height = val );
-                                                                        },
-                                                                        onChange : function()
-                                                                        {
-                                                                                var styles = this.getDialog().getContentElement( 'advanced', 'advStyles' ),
-                                                                                        value = this.getValue();
-                                                                                styles && styles.updateStyle( 'height', value );
                                                                         }
                                                                 },

CKEditor/trunk/_source/plugins/pastefromword/filter/default.js

@@ -262 +262 @@
                                                                                 // Deal with component/short-hand form.
                                                                                 var values = margin.split( ' ' );
-                                                                                margin = plugin.utils.convertToPx( values[ 3 ] || values[ 1 ] || values [ 0 ] );
-                                                                                margin = parseInt( margin, 10 );
+                                                                                margin = CKEDITOR.tools.convertToPx( values[ 3 ] || values[ 1 ] || values [ 0 ] );
 
                                                                                 // Figure out the indent unit by checking the first time of incrementation.
@@ -311 +310 @@
                         },
 
-                        // Convert various length units to 'px' in ignorance of DPI.
-                        convertToPx : ( function ()
-                        {
-                                var calculator = CKEDITOR.dom.element.createFromHtml(
-                                                                '<div style="position:absolute;left:-9999px;' +
-                                                                'top:-9999px;margin:0px;padding:0px;border:0px;"' +
-                                                                '></div>', CKEDITOR.document );
-                                CKEDITOR.document.getBody().append( calculator );
-
-                                return function( cssLength )
-                                {
-                                        if ( cssLengthRelativeUnit.test( cssLength ) )
-                                        {
-                                                calculator.setStyle( 'width', cssLength );
-                                                return calculator.$.clientWidth + 'px';
-                                        }
-
-                                        return cssLength;
-                                };
-                        } )(),
-
                         // Providing a shorthand style then retrieve one or more style component values.
                         getStyleComponents : ( function()
@@ -414 +392 @@
                                                                         {
                                                                                 var margin = val.split( ' ' )[ 1 ].match( cssLengthRelativeUnit );
-                                                                                margin && ( previousListItemMargin = parseInt( plugin.utils.convertToPx( margin[ 0 ] ), 10 ) );
+                                                                                margin && ( previousListItemMargin = CKEDITOR.tools.convertToPx( margin[ 0 ] ) );
                                                                         } ],
                                                                         ( level == 1 ? [ 'mso-list', null, function( val )
@@ -779 +757 @@
                                 containsNothingButSpaces = this.utils.isContainingOnlySpaces,
                                 resolveListItem = this.utils.resolveList,
-                                convertToPx = this.utils.convertToPx,
+                                convertToPx = function( value )
+                                        {
+                                                value = CKEDITOR.tools.convertToPx( value );
+                                                return isNaN( value ) ? value : value + 'px';
+                                        },
                                 getStyleComponents = this.utils.getStyleComponents,
                                 listDtdParents = this.utils.listDtdParents,