id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
11034	IframeDialog has very small content in CKEditor 4 continued.	Jakub Ś		"This is the continuation of ticket #10610.

There are two methods of adding iframedialog to editor:

1. CKEDITOR.dialog.addIframe method which is used when you only want to have iframe in dialog. The height of iframe (or rather wrapping div) was fixed in #10610.

2. There is also possibility to add iframe to dialog (sample code below).This method is used when you want to have something more in dialog except for iframe. **Furthermore this method isn't fixed by #10610**. It works when you define width and height in pixels but doesn't when you define % for iframe dimentions. 
{{{
ontents :
                       [
                          {
                             id : 'iframe',
                             label : 'some label...',
                             expand : true,
                             elements :
                                   [
                                      {
                                         type : 'iframe',                                       
}}}


To summarize: **adding iframe as contents and setting height to 100% will result in small iframe.**

----

**Why this is happening:**  Div surrounding iframe has height auto and all elements inside it (when you define % for iframe) are % so the wrapping div will never get dialog height in this case. [[BR]]
Please go to:
{{{ ckeditor4\plugins\dialog\plugin.js}}} [[BR]]
Line 1039 [[BR]]
In CKE 4.x this line is style: {{{contents.style || 'width: 100%;'}}} while in 3.x this was {{{style: contents.style || 'width: 100%;height:100%;'}}}. **Bringing back height fixes this issue.**


Ticket #10610 didn't involve fixing dialog plugin but iframedialog plugin. **As discussed with @fredck, fix from #10610 did its job in 50%. It should be checked why doesn't it work for second case and if something can be done about it.**

I’m attaching sample plugin for testing.
"	Bug	confirmed	Normal		General	4.0 Beta