Changes between Initial Version and Version 1 of Ticket #11909, comment 5


Ignore:
Timestamp:
May 7, 2014, 9:37:31 AM (10 years ago)
Author:
Piotrek Koszuliński
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11909, comment 5

    initial v1  
    1 The case 1 can be easily solved by using resetUndo and resetDirty in setData's callback. However, case 2 is more troublesome and shows clearly that the best solution will be if we introduce such option for setData. Of course there are workarounds like - cancelling specific saveSnapshot events, but that's not a nice thing.
     1The case 1. can be easily solved by using `resetUndo` and `resetDirty` in setData's callback. However, the case 2. is more troublesome and shows clearly that the best solution will be if we introduce such option for setData. Of course there are workarounds like - cancelling specific `saveSnapshot` events, but that's not a nice thing.
    22
    3 The only problem I have is the parameters order in setData. Currently we have: data, callback, internal. The last parameter is mostly for editor's internal usage, but it's documented in the API so it may be uncool to change it. So the new parameter would have to be added at the end and this starts to look bad.
     3The only problem I have is the parameters order in `setData`. Currently we have: data, callback, internal. The last parameter is mostly for editor's internal usage, but it's documented in the API so it may be uncool to change it. So the new parameter would have to be added at the end and this starts to look bad.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy