Opened 6 months ago

Closed 7 weeks ago

#14894 closed Bug (fixed)

Editor scrolls to top when focused or when dialog is opened.

Reported by: j.swiderski Owned by: Tade0
Priority: Normal Milestone: CKEditor 4.7.0
Component: General Version:
Keywords: Chrome Cc:

Description

Steps to reproduce

These are two issues in fact. First one concerns opening dialog when editor is not focused and second one is the continuation of #14659.

Test Case 1

  1. http://dev.ckeditor.com/ticket/14659#comment:6. Test case from that comment is still reproducible (starting from 4.0.0).

Test Case 2

  1. Open sample page - replacebycode.html or divarea.html
  2. Scroll editor a little bit without focusing it
  3. Open Link dialog

This test case can be reproduced in both classic (starting from 4.4.6) and divarea editor (starting from 4.0.0)

Expected result

Editor should not scroll.

Actual result

In both cases editor will be scrolled to top.

Other details (browser, OS, CKEditor version, installed plugins)

Problem can be reproduced in Chrome browser only

Change History (8)

comment:1 Changed 6 months ago by j.swiderski

  • Status changed from new to confirmed

comment:2 Changed 4 months ago by m.lewandowski

  • Milestone changed from CKEditor 4.6.1 to CKEditor 4.6.2

Moving to 4.6.2 minor release, as 4.6.1 is mostly about polishing 4.6.0.

comment:3 Changed 3 months ago by m.lewandowski

  • Milestone changed from CKEditor 4.6.2 to CKEditor 4.7.0

comment:4 Changed 2 months ago by Tade0

  • Owner set to Tade0
  • Status changed from confirmed to assigned

comment:5 Changed 2 months ago by Tade0

  • Status changed from assigned to review

Here's an admittedly blunt, yet working solution.

Reasoning: we have no control over what exaclty happens when a native method is called, so we need to work around it.

Changes pushed to branch:t/14894.

comment:6 follow-up: Changed 8 weeks ago by t.jakut

  • Status changed from review to review_failed

Fix is working fine, but it lacks unit test. It shouldn't be too hard to create. I'm also not sure if it wouldn't be better to apply this fix only to Chrome.

comment:7 in reply to: ↑ 6 Changed 8 weeks ago by Tade0

  • Status changed from review_failed to review

Replying to t.jakut:

I'm also not sure if it wouldn't be better to apply this fix only to Chrome.

Yeah, I probably should.

Added unit test, changes pushed to branch:t/14894.

comment:8 Changed 7 weeks ago by t.jakut

  • Resolution set to fixed
  • Status changed from review to closed

LGTM, I've just polished it a bit and merged to major with git:af78e85.

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy