Ticket #1272: 1272.patch

_source/core/dom/text.js

@@ -67 +67 @@
                         return this.$.nodeValue;
                 },
 
+                setText : function( text )
+                {
+                        this.$.nodeValue = text;
+                },
+
                 /**
                  * Breaks this text node into two nodes at the specified offset,
                  * keeping both in the tree as siblings. This node then only contains

_source/plugins/editingblock/plugin.js

@@ -152 +152 @@
          */
         CKEDITOR.editor.prototype.setMode = function( mode )
         {
+                this.fire( 'beforeSetMode', { newMode : mode } );
+
                 var data,
                         holderElement = this.getThemeSpace( 'contents' ),
                         isDirty = this.checkDirty();

_source/plugins/selection/plugin.js

@@ -98 +98 @@
                 canUndo : false
         };
 
+        var fillingChar,
+                fillingCharReady;
+
+        // Checks if a filling char has been used, eventualy removing it (#1272).
+        function checkFillingChar()
+        {
+                if ( fillingChar )
+                {
+                        if ( fillingCharReady )
+                        {
+                                // We can't simply remove the filling node because the user
+                                // will actually enlarge it when typing, so we just remove the
+                                // invisible char from it.
+                                fillingChar.setText( fillingChar.getText().replace( /\u200B/g, '' ) );
+                                fillingChar = 0;
+                        }
+
+                        // Use this flag to avoid removing the filling char right after
+                        // creating it.
+                        fillingCharReady = !fillingCharReady;
+                }
+        }
+
         CKEDITOR.plugins.add( 'selection',
         {
                 init : function( editor )
                 {
+                        // On WebKit only, we need a special "filling" char on some situations
+                        // (#1272). Here we set the events that should invalidate that char.
+                        if ( CKEDITOR.env.webkit )
+                        {
+                                editor.on( 'selectionChange', checkFillingChar );
+                                editor.on( 'beforeSetMode', checkFillingChar );
+                                editor.on( 'key', function( e )
+                                        {
+                                                // Remove the filling char before the left-key is
+                                                // executed, so it'll not get blocked by it.
+                                                if ( e.data.keyCode == 37 )
+                                                        checkFillingChar();
+                                        });
+                        }
+
                         editor.on( 'contentDom', function()
                                 {
                                         var doc = editor.document,
@@ -1137 +1175 @@
                                 var sel = this.getNative();
 
                                 if ( ranges.length )
+                                {
                                         sel.removeAllRanges();
+                                        // Remove any existing filling char first.
+                                        CKEDITOR.env.webkit && checkFillingChar();
+                                }
 
                                 for ( var i = 0 ; i < ranges.length ; i++ )
                                 {
@@ -1187 +1229 @@
                                                 startContainer.appendText( '' );
                                         }
 
+                                        if ( range.collapsed && CKEDITOR.env.webkit )
+                                        {
+                                                // Append a zero-width space so WebKit will not try to
+                                                // move the selection by itself (#1272).
+                                                fillingChar = new CKEDITOR.dom.text( '\u200B' );
+                                                range.insertNode( fillingChar ) ;
+                                                range.moveToPosition( fillingChar, CKEDITOR.POSITION_AFTER_END );
+                                        }
+
                                         nativeRange.setStart( startContainer.$, range.startOffset );
                                         nativeRange.setEnd( range.endContainer.$, range.endOffset );
 
@@ -1375 +1426 @@
                 :
                         function()
                         {
-                                var startContainer = this.startContainer;
-
-                                // If we have a collapsed range, inside an empty element, we must add
-                                // something to it, otherwise the caret will not be visible.
-                                if ( this.collapsed && startContainer.type == CKEDITOR.NODE_ELEMENT && !startContainer.getChildCount() )
-                                        startContainer.append( new CKEDITOR.dom.text( '' ) );
-
-                                var nativeRange = this.document.$.createRange();
-                                nativeRange.setStart( startContainer.$, this.startOffset );
-
-                                try
-                                {
-                                        nativeRange.setEnd( this.endContainer.$, this.endOffset );
-                                }
-                                catch ( e )
-                                {
-                                        // There is a bug in Firefox implementation (it would be too easy
-                                        // otherwise). The new start can't be after the end (W3C says it can).
-                                        // So, let's create a new range and collapse it to the desired point.
-                                        if ( e.toString().indexOf( 'NS_ERROR_ILLEGAL_VALUE' ) >= 0 )
-                                        {
-                                                this.collapse( true );
-                                                nativeRange.setEnd( this.endContainer.$, this.endOffset );
-                                        }
-                                        else
-                                                throw( e );
-                                }
-
-                                var selection = this.document.getSelection().getNative();
-                                // getSelection() returns null in case when iframe is "display:none" in FF. (#6577)
-                                if ( selection )
-                                {
-                                        selection.removeAllRanges();
-                                        selection.addRange( nativeRange );
-                                }
+                                this.document.getSelection().selectRanges( [ this ] );
                         };
 } )();