Ticket #2514: 2514_3.patch

_source/core/tools.js

@@ -299 +299 @@
          * @returns {Number} The (zero based) index of the first entry that matches
          *              the entry, or -1 if not found.
          * @example
-         * var letters = [ 'a', 'b', 'c' ];
-         * alert( CKEDITOR.tools.indexOf( letters, 'b' ) );  "1"
+         * var letters = [ 'a', 'b', 0, 'c', false ]; 
+         * alert( CKEDITOR.tools.indexOf( letters, '0' ) );  "-1" because 0 !== '0' 
+         * alert( CKEDITOR.tools.indexOf( letters, false ) );  "4" because 0 !== false 
          */
-        indexOf : function( array, entry )
-        {
-                for ( var i = 0, len = array.length ; i < len ; i++ )
-                {
-                        if ( array[ i ] == entry )
-                                return i;
-                }
-                return -1;
-        },
+        indexOf :
+                // #2514: We should try to use Array.indexOf if it does exist.
+                // [].indexOf works everywhere if the the browser implementation is available.
+                ( [].indexOf ) ?
+                        function( array, entry )
+                                {
+                                        return index = array.indexOf( entry );
+                                }
+                :
+                        function( array, entry )
+                        {
+                                for ( var i = 0, len = array.length ; i < len ; i++ )
+                                {
+                                        if ( array[ i ] === entry )
+                                                return i;
+                                }
+                                return -1;
+                        },
 
         bind : function( func, obj )
         {