Ticket #3403: 3403_3.patch

_source/plugins/forms/dialogs/textfield.js

@@ -11 +11 @@
                 maxLength : 1
         };
 
-        var ieDefaults =
-        {
-                size : 20,
-                maxLength : 0x7fffffff
-        };
-
         var acceptedTypes =
         {
                 text : 1,
@@ -58 +52 @@
                 {
                         var autoSetup = function( element )
                         {
-                                var value = element.getAttribute( this.id );
-                                if ( CKEDITOR.env.ie && ( this.id in ieDefaults ) && ieDefaults[ this.id ] == value )
-                                        this.setValue( '' );
-                                else
-                                        this.setValue( element.getAttribute( this.id ) || '' );
+                                var value = element.hasAttribute( this.id ) && element.getAttribute( this.id );
+                                this.setValue( value || '' );
                         };
 
                         var autoCommit = function( data )

_source/plugins/forms/dialogs/textarea.js

@@ -70 +70 @@
                                                 validate : CKEDITOR.dialog.validate.integer( editor.lang.common.validateNumberFailed ),
                                                 setup : function( element )
                                                 {
-                                                        var ieDefault = 20;
-                                                        var value = element.getAttribute( 'cols' );
-                                                        this.setValue( ( CKEDITOR.env.ie && ( value == ieDefault ) ? '' : value ) || '' );
+                                                        var value = element.hasAttribute( 'cols' ) && element.getAttribute( 'cols' );
+                                                        this.setValue( value || '' );
                                                 },
                                                 commit : function( element )
                                                 {
@@ -92 +91 @@
                                                 validate : CKEDITOR.dialog.validate.integer( editor.lang.common.validateNumberFailed ),
                                                 setup : function( element )
                                                 {
-                                                        var ieDefault = 2;
-                                                        var value = element.getAttribute( 'rows' );
-                                                        this.setValue( ( CKEDITOR.env.ie && ( value == ieDefault ) ? '' : value ) || '' );
+                                                        var value = element.hasAttribute( 'rows' ) && element.getAttribute( 'rows' );
+                                                        this.setValue( value || '' );
                                                 },
                                                 commit : function( element )
                                                 {

_source/plugins/forms/plugin.js

@@ -164 +164 @@
         },
         requires : [ 'image' ]
 } );
+
+if ( CKEDITOR.env.ie )
+{
+        CKEDITOR.dom.element.prototype.hasAttribute = function( name )
+        {
+                var $attr = this.$.attributes.getNamedItem( name );
+
+                if ( this.getName() == 'input' )
+                {
+                        switch ( name )
+                        {
+                                case 'class' :
+                                        return this.$.className.length > 0;
+                                case 'checked' :
+                                        return !!this.$.checked;
+                                case 'value' :
+                                        var type = this.getAttribute( 'type' );
+                                        if ( type == 'checkbox' || type == 'radio' )
+                                                return this.$.value != 'on';
+                                        break;
+                                default:
+                        }
+                }
+
+                return !!( $attr && $attr.specified );
+        };
+}

_source/core/dom/element.js

@@ -804 +804 @@
                                 },
 
                 /**
+                 * Indicates whether a specified attribute is defined for this element.
+                 * @returns {Boolean} True if the specified attribute is defined.
+                 * @param (String) name The attribute name.
+                 * @example
+                 */
+                hasAttribute : function( name )
+                {
+                        var $attr = this.$.attributes.getNamedItem( name );
+                        return !!( $attr && $attr.specified );
+                },
+
+                /**
                  * Hides this element (display:none).
                  * @example
                  * var element = CKEDITOR.dom.element.getById( 'myElement' );