Ticket #4032: 4032.patch

_source/plugins/richcombo/plugin.js

@@ -49 +49 @@
                 {
                         panelDefinition : panelDefinition,
                         items : {},
-                        state : CKEDITOR.TRISTATE_OFF
+                        state : CKEDITOR.TRISTATE_OFF,
+                        value : ''
                 };
         },
 
@@ -279 +280 @@
 
                 setValue : function( value, text )
                 {
-                        this._.value = value;
-
-                        var textElement = this.document.getById( 'cke_' + this.id + '_text' );
+                        if ( this._.value != value )
+                        {
+                                var textElement = this.document.getById( 'cke_' + this.id + '_text' );
 
-                        if ( !value )
-                        {
-                                text = this.label;
-                                textElement.addClass( 'cke_inline_label' );
-                        }
-                        else
-                                textElement.removeClass( 'cke_inline_label' );
-                        textElement.setHtml( typeof text != 'undefined' ? text : value );
+                                if ( !value )
+                                {
+                                        text = this.label;
+                                        textElement.addClass( 'cke_inline_label' );
+                                }
+                                else
+                                        textElement.removeClass( 'cke_inline_label' );
+                                // IE8 fluctuates the rendering layout when update inner HTML,
+                                // do it off the DOM.(#4032)
+                                if ( CKEDITOR.env.ie8 )
+                                {
+                                        var parent = textElement.getParent();
+                                        textElement.remove();
+                                }
+                                textElement.setHtml( typeof text != 'undefined' ? text : value );
+                                if ( CKEDITOR.env.ie8 )
+                                        parent.append( textElement );
+                        }
+
+                        this._.value = value;
                 },
 
                 getValue : function()

_source/plugins/button/plugin.js

@@ -199 +199 @@
                 {
                         element.setState( state );
 
-                        var htmlTitle = this.title,
-                                unavailable = this._.editor.lang.common.unavailable,
-                                labelElement = element.getChild( 1 );
+                        if ( this._.state == CKEDITOR.TRISTATE_DISABLED
+                                 || state == CKEDITOR.TRISTATE_DISABLED )
+                        {
+                                var htmlTitle = this.title,
+                                        unavailable = this._.editor.lang.common.unavailable,
+                                        labelElement = element.getChild( 1 );
 
-                        if ( state == CKEDITOR.TRISTATE_DISABLED )
-                                htmlTitle = unavailable.replace( '%1', this.title );
+                                if ( state == CKEDITOR.TRISTATE_DISABLED )
+                                        htmlTitle = unavailable.replace( '%1', this.title );
 
-                        labelElement.setHtml( htmlTitle );
-                }
+                                // IE8 fluctuates the rendering layout when update inner HTML,
+                                // do it off the DOM.(#4032)
+                                if ( CKEDITOR.env.ie8 )
+                                        labelElement.remove();
+                                labelElement.setHtml( htmlTitle );
+                                if ( CKEDITOR.env.ie8 )
+                                        element.append( labelElement );
+                        }
+                }
 
                 this._.state = state;
         }

CHANGES.html

@@ -162 +162 @@
                         ckeditor2.html test case.</li>
                 <li><a href="http://dev.fckeditor.net/ticket/3989">#3989</a> : Host page horizontal scrolling a lot when on having righ-to-left direction.</li>
                 <li><a href="http://dev.fckeditor.net/ticket/4001">#4001</a> : Create link around existing image result incorrect.</li>
+                <li><a href="http://dev.fckeditor.net/ticket/4032">#4032</a> : [IE8] Fixed toolbar height fluctuating when document is focused.</li>
         </ul>
         <h3>
                 CKEditor 3.0 RC</h3>