Ticket #4387: 4387_2.patch

_source/skins/kama/skin.js

@@ -85 +85 @@
                         if ( CKEDITOR.env.webkit )
                         {
                                 uiColorMenuCss = uiColorMenuCss.split( '}' ).slice( 0, -1 );
-                                for ( var i in uiColorMenuCss )
-                                                uiColorMenuCss[ i ] = uiColorMenuCss[ i ].split( '{' );
+                                for ( var i = 0 ; i < uiColorMenuCss.length ; i++ ) 
+                                        uiColorMenuCss[ i ] = uiColorMenuCss[ i ].split( '{' );
                         }
 
                         function addStylesheet( document )
@@ -100 +100 @@
                         
                         function updateStylesheets( styleNodes, styleContent, replace )
                         {
-                                for ( var id in styleNodes )
+                                var r, i, content;
+                                for ( var id  = 0 ; id < styleNodes.length ; id++ )
                                 {
                                         if ( CKEDITOR.env.webkit )
                                         {
                                                 // Truncate manually.
-                                                for ( var i = 0 ; i < styleNodes[ id ].$.sheet.rules.length ; i++ )
+                                                for ( i = 0 ; i < styleNodes[ id ].$.sheet.rules.length ; i++ )
                                                         styleNodes[ id ].$.sheet.removeRule( i );
 
-                                                for ( var i in styleContent )
+                                                for ( i = 0 ; i < styleContent.length ; i++ )
                                                 {
-                                                        var content = styleContent[ i ][ 1 ];
-                                                        for ( var r in replace )
+                                                        content = styleContent[ i ][ 1 ];
+                                                        for ( r  = 0 ; r < replace.length ; r++ )
                                                                 content = content.replace( replace[ r ][ 0 ], replace[ r ][ 1 ] );
 
                                                         styleNodes[ id ].$.sheet.addRule( styleContent[ i ][ 0 ], content );
@@ -119 +120 @@
                                         }
                                         else
                                         {
-                                                var content = styleContent;
-                                                for ( var r in replace )
+                                                content = styleContent;
+                                                for ( r  = 0 ; r < replace.length ; r++ )
                                                         content = content.replace( replace[ r ][ 0 ], replace[ r ][ 1 ] );
 
                                                 if ( CKEDITOR.env.ie )

CHANGES.html

@@ -64 +64 @@
                 <li><a href="http://dev.fckeditor.net/ticket/3568">#3568</a> : Dialogs now select all text when tabbing to text inputs.</li>
                 <li><a href="http://dev.fckeditor.net/ticket/3727">#3727</a> : Cell Properties dialog was missing color selection option.</li>
                 <li><a href="http://dev.fckeditor.net/ticket/3517">#3517</a> : Fixed "Match cyclic" field in Find & Replace dialog.</li>
+                <li><a href="http://dev.fckeditor.net/ticket/4387">#4387</a> : Right clicking in Kama skin can lead to a javascript error.</li>
         </ul>
         <h3>
                 CKEditor 3.0</h3>