Ticket #4640: 4640.patch

_source/plugins/filebrowser/plugin.js

@@ -335 +335 @@
                         return false;
                 }
 
-                return ( definition.getContents( tabId ).get( elementId ).filebrowser && definition.getContents( tabId ).get( elementId ).filebrowser.url );
+                var elementFileBrowser = definition.getContents( tabId ).get( elementId ).filebrowser;
+                return ( elementFileBrowser && elementFileBrowser.url );
         }
 
         function setUrl( fileUrl, data )
@@ -366 +367 @@
 
                         CKEDITOR.on( 'dialogDefinition', function( evt )
                         {
+                                var definition = evt.data.definition,
+                                        element;
                                 // Associate filebrowser to elements with 'filebrowser' attribute.
-                                for ( var i in evt.data.definition.contents )
+                                for ( var i in definition.contents )
                                 {
-                                        attachFileBrowser( evt.editor, evt.data.name, evt.data.definition, evt.data.definition.contents[ i ].elements );
-                                        if ( evt.data.definition.contents[ i ].hidden && evt.data.definition.contents[ i ].filebrowser )
+                                        element = definition.contents[ i ] ;
+                                        attachFileBrowser( evt.editor, evt.data.name, definition, element.elements );
+                                        if ( element.hidden && element.filebrowser )
                                         {
-                                                evt.data.definition.contents[ i ].hidden =
-                                                        !isConfigured( evt.data.definition, evt.data.definition.contents[ i ][ 'id' ], evt.data.definition.contents[ i ].filebrowser );
+                                                element.hidden = !isConfigured( definition, element[ 'id' ], element.filebrowser );
                                         }
                                 }
                         } );

CHANGES.html

@@ -44 +44 @@
         <p>
                 Fixed issues:</p>
         <ul>
-                <li></li>
+                <li><a href="http://dev.fckeditor.net/ticket/4640">#4640</a> : Small optimizations for the fileBrowser plugin.</li>
         </ul>
         <h3>
                 CKEditor 3.1</h3>