Ticket #6099: 6099_5.patch

_source/plugins/bidi/plugin.js

@@ -9 +9 @@
         var directSelectionGuardElements = {};
         CKEDITOR.tools.extend( directSelectionGuardElements, guardElements, { tr:1, p:1, div:1, li:1 } );
 
-        function onSelectionChange( evt )
+        function setToolbarStates( evt )
         {
                 var editor = evt.editor,
                         path = evt.data.path;
@@ -18 +18 @@
 
                 useComputedState = useComputedState === undefined || useComputedState;
 
-                if ( useComputedState )
+                // We can use computedState provided by the browser or traverse parents manually.
+                if ( !useComputedState )
                 {
-                        var selection = editor.getSelection(),
-                                ranges = selection.getRanges();
+                        selectedElement = path.elements[ 0 ];
 
-                        selectedElement = ranges && ranges[ 0 ].getEnclosedNode();
-
-                        // If this is not our element of interest, apply to fully selected elements from guardElements.
-                        if ( !selectedElement || selectedElement
-                                        && !( selectedElement.type == CKEDITOR.NODE_ELEMENT && selectedElement.getName() in directSelectionGuardElements )
-                                )
-                                selectedElement = getFullySelected( selection, guardElements );
-                }
+                        while ( !( selectedElement.getName() in directSelectionGuardElements || selectedElement.is( 'body' ) ) )
+                        {
+                                var parent = selectedElement.getParent();
+                                if ( !parent )
+                                        break;
+                                
+                                selectedElement = parent;
+                        }
+                }
 
                 selectedElement = selectedElement || path.block || path.blockLimit;
 
@@ -43 +44 @@
 
                 editor.getCommand( 'bidirtl' ).setState( selectionDir == 'rtl' ? CKEDITOR.TRISTATE_ON : CKEDITOR.TRISTATE_OFF );
                 editor.getCommand( 'bidiltr' ).setState( selectionDir == 'ltr' ? CKEDITOR.TRISTATE_ON : CKEDITOR.TRISTATE_OFF );
+        }
 
+        function handleMixedDirContent( evt )
+        {
                 var chromeRoot = editor.container.getChild( 1 );
-
-                if ( selectionDir != editor.lang.dir )
+                var node = evt.data.path.elements[ 0 ];
+                
+                if ( node && editor.lang.dir != evt.data.path.elements[ 0 ].getComputedStyle( 'direction' ) )
                         chromeRoot.addClass( 'cke_mixed_dir_content' );
                 else
                         chromeRoot.removeClass( 'cke_mixed_dir_content' );
@@ -240 +245 @@
                         addButtonCommand( 'BidiLtr', lang.ltr, 'bidiltr', bidiCommand( 'ltr' ) );
                         addButtonCommand( 'BidiRtl', lang.rtl, 'bidirtl', bidiCommand( 'rtl' ) );
 
-                        editor.on( 'selectionChange', onSelectionChange );
+                        editor.on( 'selectionChange', function( e )
+                        {
+                                setToolbarStates( e );
+                                handleMixedDirContent( e );
+                        });
                 }
         });