Ticket #6376: 6376_3.patch

_source/plugins/bidi/plugin.js

@@ -1 @@
-/*
+/*
 Copyright (c) 2003-2010, CKSource - Frederico Knabben. All rights reserved.
 For licensing, see LICENSE.html or http://ckeditor.com/license
 */
@@ -52 +52 @@
                         chromeRoot.removeClass( 'cke_mixed_dir_content' );
         }
 
-        function switchDir( element, dir, editor, state )
+        function switchDir( element, dir, editor )
         {
+                var useComputedState = editor.config.useComputedState;
+                useComputedState = useComputedState === undefined || useComputedState;
+                
+                var elementDir = useComputedState ? element.getComputedStyle( 'direction' )
+                        : element.getStyle( 'direction' ) || element.hasAttribute( 'dir' );
+
+                // Stop if direction is same as present.
+                if ( elementDir == dir )
+                        return;
+
                 var dirBefore = element.getComputedStyle( 'direction' );
 
-                element.removeStyle( 'direction' );
                 element.removeAttribute( 'dir' );
+                element.setStyle( 'direction', dir );
 
-                if ( state == CKEDITOR.TRISTATE_OFF && element.getComputedStyle( 'direction' ).toLowerCase() != dir )
-                        element.setAttribute( 'dir', dir );
-
                 // If the element direction changed, we need to switch the margins of
                 // the element and all its children, so it will get really reflected
                 // like a mirror. (#5910)
@@ -70 +77 @@
                         editor.fire( 'dirChanged', element );
 
                 editor.forceNextSelectionCheck();
+
+                return null;
         }
 
         function getFullySelected( selection, elements )
@@ -108 +117 @@
                                 if ( selectedElement )
                                 {
                                         if ( !selectedElement.isReadOnly() )
-                                                switchDir( selectedElement, dir, editor, this.state );
+                                                switchDir( selectedElement, dir, editor );
                                 }
                                 else
                                 {
@@ -135 +144 @@
 
                                                 while ( ( block = walker.next() ) )
                                                 {
-                                                        switchDir( block, dir, editor, this.state );
+                                                        switchDir( block, dir, editor );
                                                         processedElements.push( block );
                                                 }
 
@@ -171 +180 @@
 
                                                         if ( !_break )
                                                         {
-                                                                switchDir( block, dir, editor, this.state );
+                                                                switchDir( block, dir, editor );
                                                         }
                                                 }
                                         }