id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
10131	undoManager.update does not refresh command state	dggtydnk	Piotrek Koszuliński	"Calls to the update() in undo Manager should also call undoManager.onChange() to refresh the state of the toolbar.  I have a command that does something like:

{{{
editor.fire(""saveSnapshot"");
editor.fire(""lockSnapshot"");
var span = new CKEDITOR.dom.element(""span"");
span.setText(""Loading..."");
editor.insertElemenent(span);
// load data into span via AJAX call here - code omitted
function ajaxLoaded(contents) {
  span.setText(contents);
  editor.fire(""unlockSnapshot"")
}
}}}

I lock the snapshot before setting the ""Loading..."" text so it does not appear in the undo history stack.

I am left with a toolbar that has both the undo and redo buttons on, even though undoManager.redoable() is false.  I think if undoManager.fireChange() (or even just undoManager.onChange()) were called in undoManager.update() (since update() is called in undoManager.unlock()), the toolbar would be in the proper state."	Bug	closed	Normal	CKEditor 4.1.1	Core : Undo & Redo	4.0	fixed