Opened 11 years ago
Closed 11 years ago
#10265 closed Bug (fixed)
For...in loop over array in filebrowser plugin
| Reported by: | Olek Nowodziński | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.1.1 |
| Component: | File Browser | Version: | 3.0 |
| Keywords: | Cc: |
Description
Extracted from the pull request.
It feels like it was since filebrowser was created.
Change History (6)
comment:1 Changed 11 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | new → review |
comment:2 Changed 11 years ago by
| Status: | review → review_passed |
|---|
The order in this particular loop does not matter, so the simplified for loop that loops over elements in reverse order is totally fine.
comment:3 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Merged into master git:8ad32febfbd90.
comment:4 Changed 11 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
There is another loop that should be fixed: https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/filebrowser/plugin.js#L362
comment:6 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Fixed directly on master with git:2be86aa.
Note: See
TracTickets for help on using
tickets.
Created branch t/10265 with the pull request + minor fixes.