Integrate remaining plugins with active filter

[Piotr Jasiun]

TODO: When cursor is moved to nested editable (using editor#activeFilterChange):

• disable useless buttons,
• disable useless drop down elements (styles etc.),
• remove or disable useless dialog fields (if it possible).

[Piotr Jasiun]

Changes:

• hide not enabled styles,
• disable style combo if none style is available,
• disable font, color, language and indent buttons if they are not available,
• disable not allowed (by requiredContent) fields and tabs in dialog,
• disable tab if all of the fields are disabled,
• add onStateUpdate method to richcombo and button plugins,
• extend logic of style.checkApplicable method,
• tests.

Changes in ​t/10848, and tests t/10848.

[Frederico Caldeira Knabben]

core/style.js

• Unfortunately this code is touching a method which has been changed on major. Better to rebase the branch before we review it finally.
• Why half of documentation for "filter"? Better to at least make it clear that it is optional and a few words about it would not hurt.

plugins/language/plugin.js

• On major we're now basing the language button state on the command state, so I think we don't need anything here any more.

As for the "onStateUpdate" idea, I would instead call it "refresh" to make it similar to commands (it is for the exact same need). Additionally, it is not need to pass "state" to this method. It can be parameter-less.

... and as usual some condign style issues :P

I was not able to do it a full review so far, but it is better to have the above worked first.

[Piotr Jasiun]

• both branches are now rebased on major,
• merged checkApplicable method and tests for it,
• I confirm that language plugin now is disabled without onStateUpdate so I removed this method,
• renamed onStateUpdate( status) to refresh(),
• fixed some code style.

[Frederico Caldeira Knabben]

I’ve made a few commits for minor stuff. Still there are some issues:

• The styles combo is behaving differently for block styles now. They don’t appear selected any more when active in the current selection.

• On richcombo, updateState is now called on 'selectionChange’. What’s the case for this? This is kinda undesirable as we have already too much stuff on ‘selectionChange’.

• On listblock, getItemElements has been added exclusively for testing purposes. This is not good as this code is useless for runtime and will endup in the release code. Better to move it to the tests code and access this._.items there directly.

[Piotr Jasiun]

• fixed block style issue,
• do not call updateState on selectionChange (in richcombo) anymore, call refresh in format plugin instead,
• moved getItemElements from dev to test.

[Piotr Jasiun]

Closed.

• ​git:d93829a
• tests:31ae7e6