Image2 need to support server file browsers

[fbfactory]

I upgraded to the Image2 plugin to be able to insert images with caption using html5 figure and figcaption elements. However, I realized the plugin does not support server file browsing, which is a total dealbreaker.

[Olek Nowodziński]

We know about this issue. We're doing our best to allow a smooth transition from image to image2.

[Olek Nowodziński]

Integration under development: ​t/10895.

[Olek Nowodziński]

Integrated Image2 with file browsers, deriving from the old image plugin (​t/10895).

Note: plugins/image2/dev/image2.html already supports CKFinder.

[Frederico Caldeira Knabben]

I was not able to enable the browse button and the upload tab by just adding the following to the config:

config.filebrowserImageBrowseUrl = '/browser/browse.php?type=Images';
config.filebrowserImageUploadUrl = '/uploader/upload.php?type=Images';

Addiotionally, I know that the old dialog has this ugly thing, but couldn't we finally make it better and have the URL field taking the whole dialog width if the button will not be shown?

[Marek Lewandowski]

hijacking this one :)

[Marek Lewandowski]

Url field will now adjust its width, but it's done in a tricky way (it alters config object). We may think about tweaking dialog a little bit, in the way that it will totally ignore rendering <td /> elements for hidden element, that would solve the problem.

[Frederico Caldeira Knabben]

The final solution is mostly fine. We just agreed that the src field will *replace* the hbox that contains it, instead of having the button simply removed.

[Marek Lewandowski]

Now it's replacing it, but its a really nasty piece of code :\ Pushed to ​t/10895

[Frederico Caldeira Knabben]

• The button is not being displayed when setting ​filebrowserBrowseUrl only.
• config.filebrowserImage2BrowseUrl has been introduced just to hack the filebrowser plugin. It's not the optimal approach for this configuration though, so better to check config.filebrowserImageBrowseUrl instead in the dialog file to be better future proof.
• The curly-braces are missing in the "if" at line 540 in dialog.

[Marek Lewandowski]

Commited to: ​t/10895

• Thanks, i was not aware of filebrowserBrowseUrl :)
  
• As for filebrowserImage2BrowseUrl i thought that it was temporary adapter rather than true hack
• curly braces were removed on purpose, afaik we don't place braces if they are not essential, but just let me know if you are sure that you want me to add braces in this case

[Frederico Caldeira Knabben]

You have two lines inside that if, so in this case curly-braces are mandatory. I've just committed it and updated the branch with latest major.

[Marek Lewandowski]

Merged to major with ​git:96b94e7d0d30.