Opened 11 years ago
Closed 11 years ago
#11075 closed Bug (fixed)
AVT: With focus on button menu & no drop-down menu displayed, pressing Down Arrow should open drop-down menu and move focus in to menu and onto the first menu item
Reported by: | Satya Minnekanti | Owned by: | Marek Lewandowski |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.3.1 |
Component: | General | Version: | 4.0 |
Keywords: | IBM | Cc: | Damian, Teresa Monahan, Irina |
Description
To reproduce the defect:
- Open any CK Sample, keep cursor in editor body.
- Press Alt + F10 to navigate in to toolbar.
- Navigate to Spell Check As You Type button menu.
- Press Down Arrow key.
Expected Result: Pressing Down Arrow will open drop-down menu and move focus into the menu and onto the first menu item. Actual Result: Focus moves to next button in the toolbar. This is a violation of Accessibility Checkpoint 2.1a & 4.1b
Look at the following link for wai-aria authoring practices for button menu & keyboard interactions for button menu http://www.w3.org/TR/wai-aria-practices/#menubutton
Change History (8)
comment:1 Changed 11 years ago by
Status: | new → confirmed |
---|---|
Version: | → 4.0 |
comment:2 Changed 11 years ago by
Owner: | set to Marek Lewandowski |
---|---|
Status: | confirmed → assigned |
comment:3 Changed 11 years ago by
editor.once( 'panelShow', function( evt ) { evt.data._.panel._.currentBlock.onKeyDown( 40 ); } );
before item.execute()
in itemKeystroke
function (toolbar.js
) should do the job.
comment:4 Changed 11 years ago by
Status: | assigned → review |
---|
Thanks a lot for help Olek. I ended up with 2 changes, one, exclusively for richcombo and second for button which has 'hasArrow' property set to true.
Richcombo required direct modification where you suggested.
As for typical buttons i added code to that switch in toolbar plugin, since whole logic is specified it already there. I think that adding it to another place would be very tricky for future maintainer.
Code pushed to t/11075 dev.
I skipped tests since interface is not convenient, so it would take lot of time to prepare it.
comment:5 Changed 11 years ago by
Status: | review → review_failed |
---|
I understand that the code is tricky as the API is limited. So the proposed solution is good.
Still an additional proposal is being included, to open the panel on ARROW-UP. This behavior is not described in the W3C recommendations so I think we should simply stick to that and avoid it.
comment:6 Changed 11 years ago by
Status: | review_failed → review |
---|
Ok so up arrow behavior is restored in t/11075.
comment:7 Changed 11 years ago by
Milestone: | → CKEditor 4.3.1 |
---|---|
Status: | review → review_passed |
comment:8 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Masterized with git:430ada97f to dev.
Yes you are right aria says that down arrow just like space or enter should open menu and focus first element in menu.
It has never worked that way from the very beginning but I'm setting start version as 4.0 since it is going to be in 4.x.