It is possible to replace content with wrong letter case

[Piotr Jasiun]

1. Open Replace by Class sample.
2. Open 'Replace' dialog.
3. Type 'APOLLO' into 'Find what' field.
4. Press 'Replace' button.
5. Check 'Match case' ckeckbox.
6. Press 'Replace' button.

Result: 'Apollo' has been replaced even though the 'Match case' was checked and case did not mach.

Probably 'Match case' button (and the rest of the find Options) should reset find tool.

[kkrzton]

There is also a case with changing text in 'Find what' field:

1. Open Replace by Class sample.
2. Open 'Replace' dialog.
3. Type 'APOLLO' into 'Find what' field.
4. Press 'Replace' button.
5. Type 'APOLLO 11' into 'Find what' field.
6. Press 'Replace' button.

Result: 'Apollo' has been replaced.

Probably the new text should be searched for and selected (or not if not found). The next 'Replace' button click should replace text.

[kkrzton]

I think it should be fixed along with #11968.

[kkrzton]

Changes in ​t/11697.

The fix introduces slight change in find/replace behavior. If match options (match case, match words) or pattern were changed after find had been performed (and text selected), the next find operation (find button click) does not perform replace operation. Instead another find is done to rematch text.

[Marek Lewandowski]

The solution looks to be good, there are only couple style issues:

• I'm missing manual tc.
• Unit tests: assert.isFalse( dialog.parts.dialog.isVisible(), 'dialog is hidden' ); - there is no reason for us to test if hiding dialog works, calling dialog.getButton( 'cancel' ).click(); is just enough.
• Unit tests: could you add assetr messages / comments to assertions in "test find and replace with pattern change - add text after pattern" and "test find and replace with pattern change - add text before pattern"? Without it it's difficult to see difference between the two.
• Please rebase it on top of the master branch. There are conflicts, but should be fairly easy to resolve.

[kkrzton]

Changes in ​t/11697.

• Added manual tc.
• Added assert messages in unit tests, also rearranged the code and test names so it's easier to understand what's going on at first glance.
• Rebased on top of the master, also squashed some commits.

[Marek Lewandowski]

Great job! Fixed with ​git:0f2ef4c49b (merged to master).