id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
12219	[Safari] UndoManager.locked volates strict mode in undo plugin	Marek Lewandowski		"While working on #11739 I found out that at least these two line violates strict mode (Safari6):
* [https://github.com/ckeditor/ckeditor-dev/blob/bc6890652402d20f9d34bbd89e5cff936c6bc821/plugins/undo/plugin.js#L684 place1]
* [https://github.com/ckeditor/ckeditor-dev/blob/bc6890652402d20f9d34bbd89e5cff936c6bc821/plugins/undo/plugin.js#L697 place2]

The reason for that is that (at least sometimes) [https://github.com/ckeditor/ckeditor-dev/blob/bc6890652402d20f9d34bbd89e5cff936c6bc821/plugins/undo/plugin.js#L494 undoManager.locked becomes a number]. And if you attempt to add new property directly to a Number object it will cause a strict violation.

Steps to repro:

1. ensure that your [https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/undo/plugin.js plugins/undo/plugin.js] has a use strict statement
2. run [http://tests.ckeditor.dev:1030/tests/plugins/undo/change plugins/undo/change] test

'''Expected result:'''[[BR]]
Tests should pass.

'''Current result:'''[[BR]]
Tests {{{test undo}}} and {{{test redo}}} will fail.

additional info:[[BR]]
1. I've pushed temp __workaround__ for this issue to [https://github.com/cksource/ckeditor-dev/tree/t/11739_safari_fix t/11739_safari_fix] branch."	Bug	closed	Normal	CKEditor 4.4.4	General		fixed