[IE8] Undo steps not recorded when clicking below the text

[Olek Nowodziński]

Occurs when body doesn't fill entire html element.

1. Open languages samples (because there's just one line of text).
2. Click below the text and type.
3. Click somewhere else below the text and type again.
4. Undo.

• Expected: only text typed in 3. should be undid.
• Actual: all typed text has been undone.

[Marek Lewandowski]

Reproduced with basic preset using keyboard, had no luck with full preset.

[Artur Delura]

I reproduced this on every browser full build (samples)

1. Open sample with following content: <p>bar baz</p>
2. Put caret here using mouse: <p>bar ^baz</p>
3. Type "X".
4. Put caret here using mouse: <p>^bar Xbaz</p>
5. Type "X".
6. Press Ctrl + Z

Actual result: <p>bar ^baz</p>

Expected behaviour is that when we change selection after making changes then snapshot should be saved. But it does not save snapshot when we put caret at the beginning of node (see point 6 - here we put caret at the same beginning of paragraph).

Deeper investigation brings me here:

Saving snapshot is handled ​here But it's unreliable, because editable has margin on each side, so clicking in margin area does not fire click event, but change selection.

Proposed solution:

To cover 100% use case let's listen selectionChange event and in callback call onNavigationKey method.

this.undoManager.editor.on( 'selectionChange', function() {
    that.onNavigationKey();
} );

[Artur Delura]

Changes in ​branch:t/12324.

[Piotrek Koszuliński]

2 tests failed in undo/pointer, because you haven't updated them.

[Piotrek Koszuliński]

Fixed on master with ​git:9fe1013.