Changes between Initial Version and Version 2 of Ticket #12635


Ignore:
Timestamp:
Nov 6, 2014, 2:38:27 PM (4 years ago)
Author:
Marek Lewandowski
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12635

    • Property Summary changed from Keyboard triggered snapshot doesn't respect undo lock to Keypress show that undo is available despite real undo count
  • Ticket #12635 – Description

    initial v2  
    1 It seems that if I'll try to lock UndoManager for snapshots, keyboard events will trigger the snapshot anyawy.
     1It seems that if I lock the UndoManager for snapshots, keyboard presses will still render undo button to indicate that undo steps are available.
    22
    331. Open any sample with CKEditor. (i.e. samples/replacebyclass.html)
     
    1818
    1919**Expected result:**[[BR]]
    20 No snapshot should be created, until we'll unlock the UndoManager.
     20No snapshot should be created, undo button should be off/unavailable.
    2121
    2222**Current result:**[[BR]]
    23 Snapshots are created anyway.
     23Undo button is enabled.
    2424
    2525Additional info:[[BR]]
    26261. Good news is that it seems not to be recent regression, as I've checked 4.3.0 and the same error occurs there.
    27272. Commands do cares about UndoManager being locked, because if you'll perform bold or any other command it will not record snapshot.
     283. Snapshots are not really recorded, you can check that by evaluating {{{CKEDITOR.instances.editor1.undoManager.snapshots.length}}}
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy