Opened 10 years ago
Last modified 10 years ago
#12690 confirmed Bug
[Safari] bender.tools.selection.setWithHtml problems with collapsed selection and inline elements
| Reported by: | Piotrek Koszuliński | Owned by: | Artur Delura |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | General | Version: | |
| Keywords: | VendorFix Webkit | Cc: |
Description (last modified by )
There are two red tests in http://tests.ckeditor.dev:1030/tests/plugins/font/font
Tested on Safari 7.1 and Safari 8.
Note: tests were marked as regressions.
Update: during the investigation one of these issues turned out to be a bug in Webkit. The other issue was fixed in our tests tools.
Change History (8)
comment:1 Changed 10 years ago by
| Milestone: | → CKEditor 4.4.7 |
|---|---|
| Status: | new → confirmed |
comment:2 Changed 10 years ago by
| Description: | modified (diff) |
|---|---|
| Summary: | [Safari] Two red tests in the font plugin → [Safari] bender.tools.selection.setWithHtml problems with collapsed selection and inline elements |
comment:3 Changed 10 years ago by
| Owner: | set to Artur Delura |
|---|---|
| Status: | confirmed → assigned |
comment:4 Changed 10 years ago by
| Status: | assigned → review |
|---|
There problem was because range in selection was not fixed. It should be done in here. Unfortunately this code was not executed because function rangeRequiresFix returned false. That was becase range.root was not an instance of CKEDITOR.editable. I fixed it in here.
Changes in branch:t/12690.
comment:5 Changed 10 years ago by
| Status: | review → assigned |
|---|
comment:6 Changed 10 years ago by
According to this test I've reported webkit issue. Current changes are in branch:t/12690b.
comment:7 Changed 10 years ago by
| Status: | assigned → pending |
|---|
comment:8 Changed 10 years ago by
| Description: | modified (diff) |
|---|---|
| Keywords: | VendorFix Webkit added |
| Milestone: | CKEditor 4.4.7 |
| Status: | pending → confirmed |
| Version: | 4.4.6 |
I merged branch:t/12690b to master with git:058a2e4.
As for the remaining regression, which is caused by the bug in Webkit, we need to wait.
I pushed git:505e786 with two tests. One using the selection.selectRanges() directly and second one using the bender.tools.selection.setWithHtml. The first test passes on Safari, the second doesn't. This means that the problem is most likely in the tools method. Therefore, I added failing tests to regressions so we can proceed with 4.4.6.
We'll check this issue in 4.4.7.