IE: Dropdowns become disabled when in maximize mode.

[Jakub Ś]

1. Open replacebycode.html sample
2. Click Maximize
3. Select header and part of first sentence in first paragraph as shown below:

   [Apollo 11
   
   Apollo 11 was the spaceflight that landed ] the first humans,...
   

4. Click and hold mouse button for a few seconds on Styles or Format dropdown.

Result: Dropdown becomes disabled.

Problem can be reproduced in IE8-10 from CKEditor 4.0.

[Artur Delura]

​Here top style is set with wrong value.

The above happens because ​this returns a weird big value.

And again the above happens because ​here

• quirks = false
• $docElem.scrollTop = 0
• body.$.scrollTop = 1633

So we end up with 1633 but should be 0.

[Artur Delura]

As we can see above body.$.scrollTop returns 1633, but actually scroll is 0. This is some ugly browser bug which was removed in IE11. Which is result of mixing various cases like setting some styles to main editable area (maximize plugin) and playing with selection.

What is wrong in CKEditor code is this:

y = box.top + ( !quirks && $docElem.scrollTop || body.$.scrollTop );

When $docElem.scrollTop is 0 and we are not in quirks mode it pick value which is ment to be used only in quirks. To fix this issue I did this:

y = box.top + ( quirks ? body.$.scrollTop : $docElem.scrollTop );

[Artur Delura]

Current changes in ​branch:t/12747. I can't reproduce issue in manual tests.

[Piotrek Koszuliński]

Replying to a.delura:

As we can see above body.$.scrollTop returns 1633, but actually scroll is 0. This is some ugly browser bug which was removed in IE11. Which is result of mixing various cases like setting some styles to main editable area (maximize plugin) and playing with selection.

What is wrong in CKEditor code is this:

y = box.top + ( !quirks && $docElem.scrollTop || body.$.scrollTop );

When $docElem.scrollTop is 0 and we are not in quirks mode it pick value which is ment to be used only in quirks. To fix this issue I did this:

y = box.top + ( quirks ? body.$.scrollTop : $docElem.scrollTop );

It reminded me about ​https://github.com/ckeditor/ckeditor-dev/commit/056c66574aa7d555cf03dc372fb91ae2c48c5458 :D

[Piotrek Koszuliński]

Great job with the patch. I only needed to improve the test, because many times I couldn't reproduce the issue. It turned out that the selection must be made in a specific way.

[Piotrek Koszuliński]

Fixed on master with ​git:69263d0.