id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
16957	[PFW] Styles.inliner.inline does not take selectors specificity into account and duplicates rules.	kkrzton	kkrzton	"== Steps to reproduce ==

Having a html in dataTransfer object like


{{{
<style>
  td { color:black; }
  .xl65 { color:#C00000; }
</style>

<td class=""xl65""> ... </td>
}}}


and using `CKEDITOR.plugins.pastefromword.styles.inliner.inline` produces a styles object like

{{{
{
  .xl65: { color: '#C00000' },
  td: { color: 'black'  }
}
}}}

Those styles are the applied to a specific element. This means the colors are applied in the incorrect order (first, color from `.xl65` class, then from `td` - which overrides the first one). The CSS order specificity should be keep in mind here. Also the inliner does not check if same style is already defined so that the resulted styles will have two `color` rules. It wille result in style like `color:#C00000;color:black;` (it is not a big issue unless the order is correct, however it might be also improved).

See:
* https://github.com/ckeditor/ckeditor-dev/blob/major/plugins/pastefromword/filter/default.js#L867
* https://github.com/ckeditor/ckeditor-dev/blob/major/plugins/pastefromword/filter/default.js#L852

Two improvements could be applied here:
* Use the proper order for CSS selectors (now there is only problem with '''single element''' and '''single class''' selectors order - copying content from Excel does not seems to create more complex selectors).
* If the rule already exists, overwrite it.
"	Bug	closed	Normal	CKEditor 4.7.0	General		fixed	PFW