Opened 8 years ago

Closed 8 years ago

#3664 closed Bug (fixed)

Insert table in empty document add extra line

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.1
Component: Core : Styles Version:
Keywords: Confirmed HasTest Review+ Cc:

Description (last modified by Garry Yao)

Reproducing Procedures

  1. Open the replace by class example page in FF;
  2. Click on 'New Page' to empty the document;
  3. Insert a default table;
    • Expected Result:
      <table border="1" cellpadding="1" cellspacing="1" style="width: 200px;">
      ...
      </table>
      <p>
      	<br />
      </p>
      
    • Actual Result: There's an paragraph established before the table:
      <p>
      	<br />
      </p>
      <table border="1" cellpadding="1" cellspacing="1" style="width: 200px;">
      ...
      </table>
      <p>
      	<br />
      </p>
      

Attachments (3)

3664.patch (2.3 KB) - added by Garry Yao 8 years ago.
3664_2.patch (1.3 KB) - added by Garry Yao 8 years ago.
3664_3.patch (1.2 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (15)

Changed 8 years ago by Garry Yao

Attachment: 3664.patch added

comment:1 Changed 8 years ago by Garry Yao

Description: modified (diff)

Not sure if we need to trim the last paragraph, so keep it in the expected result.

comment:2 Changed 8 years ago by Garry Yao

Keywords: Review? added
Status: newassigned

comment:3 Changed 8 years ago by Artur Formella

With this patch it is not possible to insert anything above the table.

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The right way to check if we're in an empty block is by checking if the range is checkStartOfBlock "and" checkEndOfBlock.

comment:5 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.0CKEditor 3.1

comment:6 Changed 8 years ago by Garry Yao

Keywords: HasTest Review? added; Review- removed

Ticket Test added at : http://ckeditor.t/tt/3664/1.html.

Changed 8 years ago by Garry Yao

Attachment: 3664_2.patch added

comment:7 in reply to:  3 Changed 8 years ago by Garry Yao

Replying to arczi:

With this patch it is not possible to insert anything above the table.

The exitable table feature is a separate topic and should be handled by other tickets, the patch is about that.

comment:8 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
  • The "children", "count", "firstChild" are still in the code (not used).
  • The "if" declaration at line 85 is missing the curly braces.

Changed 8 years ago by Garry Yao

Attachment: 3664_3.patch added

comment:9 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:10 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:11 Changed 8 years ago by Garry Yao

Fixed with [4344].

comment:12 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy