Opened 8 years ago

Closed 8 years ago

#3759 closed Bug (fixed)

Replace all only searches to the end of the document

Reported by: Damian Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: 3.0RC IBM Review+ Cc:

Description

When using replace all in a document and the cursor was placed in the middle of the document, the search only replaces those instances between the cursor and the end of the document.

Attachments (2)

3759.patch (4.2 KB) - added by Garry Yao 8 years ago.
3759_2.patch (1.0 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by Garry Yao

Attachment: 3759.patch added

comment:1 Changed 8 years ago by Garry Yao

Keywords: RC Review? added
Owner: set to Garry Yao
Status: newassigned

comment:2 Changed 8 years ago by Garry Yao

Two updates, now with Match cyclic checked:

  1. The replace action will happen within full document;
  2. The find action will automatically start from document start without an 'alert' stopping.

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: 3.0RC added; RC removed

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

It would be better if this fix could be limited to the reported case, not changing the current "cyclic" behavior for find and replace.

Changed 8 years ago by Garry Yao

Attachment: 3759_2.patch added

comment:5 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

Now the replacement will happen at whole document range independent of cyclic.

comment:6 Changed 8 years ago by Martin Kou

Keywords: Review+ added; Review? removed

Please remember to commit #3757 as well as replace is totally broken without it.

comment:7 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3707].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy