Opened 8 years ago

Closed 8 years ago

#3785 closed Bug (fixed)

[IE8] CKEDITOR.tools.htmlEncode returns NBSPs in IE8

Reported by: Martin Kou Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (CKEditor) - OLD
Keywords: IE Confirmed Review+ Cc:

Description (last modified by Tobiasz Cudnik)

CKEDITOR.tools.htmlEncode returns NBSPs in IE8.

Smiley dialog layout is wrong

To reproduce:

  1. Open smiley dialog in IE8.
  2. The table containing the icons does not fill the dialog.

Snippet

CKEDITOR.tools.htmlEncode('  ')

Attachments (2)

3785.patch (730 bytes) - added by Tobiasz Cudnik 8 years ago.
Quickfix
3785_2.patch (845 bytes) - added by Tobiasz Cudnik 8 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newassigned

Changed 8 years ago by Tobiasz Cudnik

Attachment: 3785.patch added

Quickfix

Changed 8 years ago by Tobiasz Cudnik

Attachment: 3785_2.patch added

comment:2 Changed 8 years ago by Tobiasz Cudnik

Component: UI : DialogsGeneral
Description: modified (diff)
Keywords: IE Confirmed Review? added
Summary: Smiley dialog layout is wrong in IE8.[IE8] CKEDITOR.tools.htmlEncode returns NBSPs in IE8

The reason was deep in CKEDITOR.tools.htmlEncode(), which relays on browser-borowed code.

comment:3 Changed 8 years ago by Garry Yao

Keywords: Review+ added; Review? removed

Pretty nice fix, but seems not need to create two variable( fix1, fix2 ) for it. And please join the comments one L244 with L245.

comment:4 Changed 8 years ago by Tobiasz Cudnik

Resolution: fixed
Status: assignedclosed

Fixed with [3768].

@Garry: Local variables you mentioned are needed, without it or using only one, we will have stack overflow (at least in IE8).

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy