id summary reporter owner description type status priority milestone component version resolution keywords cc 37 Cleaning of strict warnings Alfonso Martínez de Lizarrondo Alfonso Martínez de Lizarrondo "In my development branch I've tried to ""fix"" many of the strict warnings because if everything is ok, then it's easier to spot any new trouble. many where due to this kind of code: {{{ if ( oToolbarSet = eToolbarTarget.__FCKToolbarSet ) }}} or {{{ while ( el = el.parentNode ) }}} in some cases I've changed the code so it's more explicit because it wasn't really clear what it was doing: {{{ oToolbarSet = eToolbarTarget.__FCKToolbarSet ; if ( oToolbarSet ) }}} for the whiles, I've wrapped most of them in an extra pair of () because it's clear that they are harmless. It raised several warnings with the code to read the attributes of an embed so I've changed to a cleaner and more extensible code: {{{ var aAttributes = [ 'scale', 'play', 'loop', 'menu', 'wmode', 'quality' ] ; for ( var iAtt = 0 ; i < aAttributes.length ; i++ ) { var oAtt = oEmbed.getAttribute( aAttributes[iAtt] ) ; if ( oAtt ) oCloned.setAttribute( aAttributes[iAtt], oAtt ) ; } }}} In several places I've made sure that the function always return a value (usually null or false). in fcktablehandler.js I've made several changes as it seemed that the file had a mix of line-endings and wasn't following the same style that other files and fixed the minor issues that brought me there. in fckdialog.html line 156 there was a reference to oTabs.length, but oTabs is an object, not an array so it doesn't have a length property. in fcktoolbarbuttonui.js line 145 there was an ""assignment to undeclared variable bEnableEvents"". That bEnableEvents variable isn't defined and used elsewhere in the _source files in fckpanel.js I've checked that the functions this.OnHide and this.OnShow does exist before calling the FCKTools.RunFunction In the file browser I've added code so it shows an alert if it can't load some xml file as XML (even if the responseStatus is 200) There are still more strict warnings, but now each warning should be checked to understand what does it means." Bug closed Normal FCKeditor 2.4 General fixed