Opened 8 years ago

Closed 8 years ago

#3903 closed Bug (fixed)

Unable to override font colors

Reported by: Josh Nisly Owned by:
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (CKEditor) - OLD
Keywords: HasPatch Review+ Cc:

Description

The config.colorButton_colors setting allows overriding the colors that are shown in the font and background color dropdowns. However, because of a bug in _source/plugins/colorbutton/plugin.js, this setting is not respected.

The solution is to check config.colorButton_colors instead of CKEDITOR.config.colorButton_colors. This is similar to how other plugins work.

Attached is a patch.

Attachments (1)

3903.patch (521 bytes) - added by Josh Nisly 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by Josh Nisly

Attachment: 3903.patch added

comment:1 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: HasPatch added; hasPatch removed
Milestone: CKEditor 3.0

comment:2 Changed 8 years ago by Garry Yao

Keywords: Review+ added

comment:3 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: newclosed

Fixed with [3830].

comment:4 Changed 8 years ago by Josh Nisly

Resolution: fixed
Status: closedreopened

[3830] only changed whitespace - the changes in the patch were never applied.

comment:5 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: reopenedclosed

Definitely it's wrong, thanks for point it out.
Fixed with [3842].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy