id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
3925	FCKDialog.OpenDialog() - wrong variable mapping (parentWindow)	Ivan Tcholakov	Martin Kou	"FCKEditor 2.6.4
This is not a ""theoretical"" note, I found this bug during development of something.

See .../_source/internals/fckdialog.js

The parameter *parentWindow* in the function OpenDialog() declaration and and the variable *topWindow* that sets a property of the dialogInfo object are the
same thing actually. Only one should stay - parentWindow or topWindow.

Here is an example for a correction:


{{{
var FCKDialog = ( function()
{

  ...

	return {
		/**
		 * Opens a dialog window using the standard dialog template.
		 */
		OpenDialog : function( dialogName, dialogTitle, dialogPage, width, height, customValue, parentWindow, resizable )
		{

			...

      // Setup the dialog info to be passed to the dialog.
			var dialogInfo =
			{
				Title : dialogTitle,
				Page : dialogPage,
				Editor : window,
				CustomValue : customValue,		// Optional
				// -------------- A correction starts here ---------------------
				//TopWindow : topWindow       // Wrong
				TopWindow : parentWindow      // Correct
				// -------------------------------------------------------------
			}

			...

		},

  ...
}}}
"	Bug	closed	Normal		UI : Dialogs	FCKeditor 2.6.4	fixed	Confirmed Review+