Opened 10 years ago

Closed 10 years ago

#3940 closed Bug (fixed)

list operation doesn't stop at table

Reported by: Garry Yao Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

Reproducing Procedures

  1. Open the attached example page.
  2. Select the table cell content, and click 'Create/Remove Bullted List'.
    • Actual Result:
      • list
        list in table
    • Expected Result:
      1. list
        • list in table

Attachments (4)

3940_TC.html (1.9 KB) - added by Garry Yao 10 years ago.
Sample page for reproducing
3940.patch (3.2 KB) - added by Tobiasz Cudnik 10 years ago.
3940_2.patch (3.3 KB) - added by Tobiasz Cudnik 10 years ago.
3940_3.patch (3.5 KB) - added by Tobiasz Cudnik 10 years ago.

Download all attachments as: .zip

Change History (13)

Changed 10 years ago by Garry Yao

Attachment: 3940_TC.html added

Sample page for reproducing

comment:1 Changed 10 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newassigned

Changed 10 years ago by Tobiasz Cudnik

Attachment: 3940.patch added

comment:2 Changed 10 years ago by Tobiasz Cudnik

Keywords: Review? added

This patch forbids to merge cell elements with table-wrapping list. It's also possible to create list selecting multiple block and table cells.

comment:3 Changed 10 years ago by Garry Yao

Keywords: Review- added; Review? removed

We should not target only the specific <td> tag on line L421:

if ( block.getName() != 'td' )

instead we could have:

if ( blockLimit.getName() != 'body' )

comment:4 Changed 10 years ago by Tobiasz Cudnik

It doesn't perform so well with blockLimit check if "body". Video TC.

comment:5 Changed 10 years ago by Garry Yao

Thanks for the video TC, I haven't test it, just want to explain my point, I mean we could group by blockLimit prior to grouping by ancestor list, and please test the patch carefully with enterkey, indent etc.

Changed 10 years ago by Tobiasz Cudnik

Attachment: 3940_2.patch added

comment:6 Changed 10 years ago by Tobiasz Cudnik

Now condition checks if blockLimit is a body or block is nested list element and then allows to grouping by list ancestor.

What's missing i think is turning off list button ON state when focusing non-list inside a table which is inside a list.

One issue is closely releted list nested inside a table from indent plugin. When clicking enter second time to create new list element, JS error is thrown and bookmarks can be found in markup. Although this issue is not an regression and exists in trunk.

Changed 10 years ago by Tobiasz Cudnik

Attachment: 3940_3.patch added

comment:7 Changed 10 years ago by Tobiasz Cudnik

Keywords: Review? added; Review- removed

Garry extended the patch by providing toolbar button state changing and correcting indent plugin issue.

comment:8 Changed 10 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:9 Changed 10 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3914].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy