Opened 8 years ago

Closed 8 years ago

#3949 closed Bug (fixed)

[IE] Preformatted edit problem

Reported by: Damian Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.0
Component: Core : Styles Version:
Keywords: IBM IE Confirmed Review+ Cc:

Description

This issue may be related to #3948.

  1. Add some preformatted content like so:
<pre>Test line 1

Test line 2</pre>
  1. Place cursor at end of line 2 and hit ENTER.

Notice that a space is added instead of a new line.

  1. Revert to content as at 1.
  2. Place cursor at end of line 1 and hit ENTER.

Result:

<pre>Test line
 1

Test line 2</pre>

The actual result should be a new line, the space and "1" should not be on the new line

Attachments (3)

3949.patch (6.0 KB) - added by Garry Yao 8 years ago.
3949_2.patch (2.9 KB) - added by Garry Yao 8 years ago.
3949_3.patch (2.3 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 8 years ago by Garry Yao

Keywords: IE Confirmed added

comment:2 Changed 8 years ago by Garry Yao

Component: GeneralCore : Styles
Owner: set to Garry Yao
Status: newassigned

There were actually two separated problem described in the description:

  1. The line break display as a space: This's been a browser rendering bug from IE, we've spotted this wrong behavior on other blocks as well, even when enterKey is creating <br>. We're hardly possible to resolve this issue at the moment;
  2. The line break is not created at the right position: This should be fixed by the ticket.

Changed 8 years ago by Garry Yao

Attachment: 3949.patch added

comment:3 Changed 8 years ago by Garry Yao

Keywords: Review? added

The culprit is inside the IE selection system where it report wrong offset position with the following text selection:

line1^\r\nline2

Based no this fault, the range system is incorrectly figure out it as:

line^1\r\nline2

The solution is just about normalizing the CRLF for IE.

comment:4 in reply to:  2 Changed 8 years ago by Garry Yao

Keywords: Review- added; Review? removed

Replying to garry.yao:

There were actually two separated problem described in the description:

  1. The line break display as a space: This's been a browser rendering bug from IE, we've spotted this wrong behavior on other blocks as well, even when enterKey is creating <br>. We're hardly possible to resolve this issue at the moment;

Thing changed, I've just find a workaround for this issue, a new patch will come soon.

Changed 8 years ago by Garry Yao

Attachment: 3949_2.patch added

comment:5 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:6 in reply to:  2 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

Replying to garry.yao:

  1. The line break display as a space: This's been a browser rendering bug from IE, we've spotted this wrong behavior on other blocks as well, even when enterKey is creating <br>. We're hardly possible to resolve this issue at the moment;

I think we could find a way to fix it, as V2 works well in this sense.

Changed 8 years ago by Garry Yao

Attachment: 3949_3.patch added

comment:7 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review- removed

comment:8 Changed 8 years ago by Garry Yao

Fred's pointing to a experienced way of fixing the IE rendering issue, it should be used rarely but a treatment for this case.

comment:9 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3898]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy