Opened 16 years ago
Closed 16 years ago
#4118 closed Bug (fixed)
The dialog drag behaves strange (sometimes)
| Reported by: | Frederico Caldeira Knabben | Owned by: | Frederico Caldeira Knabben |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | UI : Dialogs | Version: | SVN (CKEditor) - OLD |
| Keywords: | Confirmed Review+ | Cc: |
Description
Sometimes when a dialog opens, the attempt to drag it behaves strnage. The dialogs sudenly moves to the border of the document and stays sliding there, not moving to the center again.
This one is difficult to reproduce. It's random, and may depend on the browser performance and dialog download time. It happend with FF3.5.
Attachments (1)
Change History (6)
Changed 16 years ago by
| Attachment: | 4118.patch added |
|---|
comment:1 Changed 16 years ago by
| Keywords: | Review? added |
|---|---|
| Status: | new → assigned |
comment:2 Changed 16 years ago by
We could simply add a dontCache flag to getSize() which would be true in first call (when centering) and first next call (drag) would cache dialog size. Or simpler - set updateSize to true after first call to getSize(). What do you think ?
Ticket you're referring to is #4084.
comment:3 Changed 16 years ago by
As now we could have some tabs enlarging the dialog size when opened, maybe my approach would also help on fixing these cases too. We should have no performance impact with it. It should be safe.
comment:4 Changed 16 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
As this thing is difficult to reproduce, I can't guarantee that this patch works. But it looks logic. Much probably the issue is related to the getSize() function, which caches the wrong size (we've dealed with it in other tickets). So, I'm just forcing it to be recalculated before start dragging.