Opened 8 years ago

Closed 8 years ago

#4450 closed Bug (fixed)

Setting column paragraph alignment generates spurious <P>'s before table

Reported by: Damian Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: SVN (CKEditor) - OLD
Keywords: IBM Confirmed Review+ Cc:

Description

To reproduce:

  1. Open nightly sample
  2. Add a table with default values
  3. Populate table with text values in each cell
  4. Select multiple columns
  5. Apply paragraph alignment (e.g. centered)
  6. Go to source


Expected result: the columns will have their content aligned as selected in step 5.

Actual result: the columns are aligned as expected, but spurious <p style="text-align: center;">&nbsp;</p> tags are added before the table

Tested on FF 3.0.14

Attachments (4)

4450.patch (1.1 KB) - added by Garry Yao 8 years ago.
2009-12-03_1218.swf (615.4 KB) - added by Frederico Caldeira Knabben 8 years ago.
Patch 1 issue (screencast) for the records.
4450_2.patch (1.6 KB) - added by Garry Yao 8 years ago.
4450_3.patch (1.5 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 8 years ago by Garry Yao

Keywords: Confirmed added
Owner: set to Garry Yao
Status: newassigned
Version: SVN (CKEditor)

Ticket Test added at : http://ckeditor.t/tt/4450/1.html.

Changed 8 years ago by Garry Yao

Attachment: 4450.patch added

comment:2 Changed 8 years ago by Garry Yao

Keywords: Review? added

Ticket TC updated.

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The patch fixed things "a bit", but not totally. I'm still having this issue. Here you have a screencast for of it:
http://screencast.com/t/OWVkN2EyMDg

Changed 8 years ago by Frederico Caldeira Knabben

Attachment: 2009-12-03_1218.swf added

Patch 1 issue (screencast) for the records.

Changed 8 years ago by Garry Yao

Attachment: 4450_2.patch added

comment:4 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:5 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

Issue after patch:

  1. Load the following HTML:
    <p>Test</p>
    
  1. Select all.
  2. Apply the "Heading 1" style.
  3. Go to source.

You'll have the following HTML:

<h1>
	&nbsp;</h1>
<h1>
	Test</h1>

An extra <h1> is being appended to the doc. By using Firebug, it's possible to verify that an empty <h1> is created in the doc when applying the style.

Changed 8 years ago by Garry Yao

Attachment: 4450_3.patch added

comment:6 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:7 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:8 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [4634].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy