Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#4772 closed Bug (fixed)

Links remain default color when painting with 'text-color'

Reported by: Sa'ar Zac Elias Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.2
Component: Core : Styles Version: 3.5.3
Keywords: Cc:

Description

To Reproduce:

  1. open the online demo or a nightly build sample.
  2. Select a sentence that contains a link and paint it in another color.
  3. notice that the sentence was painted but the link wasn't.

-repeat the reproduction, just instead of a full sentence, select just a link.

this is the normal behavior of the browser, but when the end-user paints a link he expects it to be painted. to fix this issue, the styled span should go inside the A tag and not out of it.

Attachments (1)

4772.patch (2.9 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 8 years ago by Garry Yao

Keywords: Confirmed added
Milestone: CKEditor 3.2

Feature alignment with #923 of v2.

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

#4943 has been marked as DUP.

comment:3 Changed 8 years ago by Alfonso Martínez de Lizarrondo

#4991 has been marked as dup

Changed 8 years ago by Garry Yao

Attachment: 4772.patch added

comment:4 Changed 8 years ago by Garry Yao

Owner: set to Garry Yao
Status: newassigned

comment:5 Changed 8 years ago by Garry Yao

Keywords: Review? added

Ticket Test added at :
http://ckeditor.t/tt/4772/1.html.

comment:6 Changed 8 years ago by Garry Yao

Instead of modifying the entire DTD for this specific case, proposing of introducing a special filter function that determinate the style's own valid parent/child element.

comment:7 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

That's a wonderful idea. Congratulations.

comment:8 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed
Version: 3.0.1SVN (CKEditor)

Fixed with [5009].

comment:9 Changed 7 years ago by Mack

Keywords: Confirmed Review+ removed
Version: SVN (CKEditor) - OLD3.5.3 (SVN - trunk)

This fix doesn't change the color of the link underline, just the text. If you go to the demo site (http://ckeditor.com/demo) and change one of the links to red, you get red text with a blue underline.

The better fix would have been to just apply the style to the tag itself: <a style="color: #FF0000".

comment:10 in reply to:  9 Changed 7 years ago by Garry Yao

Replying to Mack:

This fix doesn't change the color of the link underline, just the text. If you go to the demo site (http://ckeditor.com/demo) and change one of the links to red, you get red text with a blue underline.

The better fix would have been to just apply the style to the tag itself: <a style="color: #FF0000".

We'd like not to mix styles in one tag (a), even this sounds a little bit imperfectness, it should be ok for most of the case.

comment:11 Changed 7 years ago by Mack

Regardless of how it is implemented, can a fix be provided for that problem? Several of our customers are complaining about their multi-colored links.

If not, I looked at changeset 5009 to see where the original fix was made, but I couldn't find that same code in newer releases. Could you point me the relevant spot in the trunk version? thanks.

comment:12 Changed 7 years ago by Garry Yao

#7212 opened for your requirement, it will not be a small change for now.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy