id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
4773	fileBrowser plugin overwrites any onClick function for a fileButton element	Alfonso Martínez de Lizarrondo	Alfonso Martínez de Lizarrondo	"The fileBrowser plugin applies its own ""fileUpload"" function to the onClick handler of the fileButtons, without any regards to any such handler specified in the definition of the object.

Unfortunately, the big anonymous function makes quite hard to workaround this or other improvements from a plugin.

The solution here is to change
{{{

if ( url )
{					
	element.onClick = uploadFile ;
	element.filebrowser.url = url;
...
}}}

to a wrapper that includes the previous handler:
{{{

if ( url )
{					
	var onClick = element.onClick;
	element.onClick = function( evt )
	{
		// ""element"" here means the definition object, so we need to find the correct
		// button to scope the event call
		var sender = evt.sender
		if ( onClick && onClick.call( sender, evt ) === false )
			return false;
		return uploadFile.call( sender, evt );
	};

	element.filebrowser.url = url;
...
}}}
"	Bug	closed	Normal	CKEditor 3.2	UI : Dialogs	3.0.1	fixed	Confirmed Review+